I agree actually. I've logged the issue https://issues.apache.org/jira/browse/GORA-449 I'm working on fixing the tests in MemStore. I'll probably pivot to this if no one else does.
On Thu, Oct 8, 2015 at 5:54 AM, Tim Robertson <timrobertson...@gmail.com> wrote: > Hi Lewis, > > I am not an HBase developer, but have done a lot of work with HBase over > the past years. > It looks rather dubious that there are 3 deletes like that, and it should > not be necessary unless there is some other race condition going on. > > I'd suggest removing those, and if an issue arises I'd be happy to take a > look. > > Cheers, > Tim > > > > > On Thu, Oct 8, 2015 at 2:07 PM, Lewis John Mcgibbney < > lewis.mcgibb...@gmail.com> wrote: > >> Yes this should be handled by the datastore. >> I have a feeling that this was inherent behavior for hBase some time ago >> and it had changed and become more robust now. >> We should confirm from hBase devs. >> >> >> On Thursday, October 8, 2015, Renato Marroquín Mogrovejo < >> renatoj.marroq...@gmail.com> wrote: >> >>> Hi Lewis, >>> >>> I think that one makes sense, we have three fields inserted, and we >>> delete the three of them. But still seems off, and that test being part of >>> core makes it even worst because this is not an HBase specific test. So for >>> every field that we added to the query object, we have to call delete? >>> shouldn't the dataStore do that by itself? >>> >>> 2015-10-08 2:40 GMT+02:00 Lewis John Mcgibbney < >>> lewis.mcgibb...@gmail.com>: >>> >>>> Hi Renato, >>>> >>>> On Wed, Oct 7, 2015 at 3:31 PM, Renato Marroquín Mogrovejo < >>>> renatoj.marroq...@gmail.com> wrote: >>>> >>>>> I also don't understand why there are three table deletes. >>>>> >>>> >>>> did you ever notice >>>> >>>> >>>> https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store/DataStoreTestUtil.java#L1041-L1043 >>>> >>>> >>>> >>> >>> >> >> -- >> *Lewis* >> >> > -- *Lewis*
