Hi Levi,

On Feb 11, 2009, at 8:39 PM, Levi Hoogenberg wrote:

I don't recall supplying a patch for Gradle,

Sorry, I have mixed it up with a patch from Jaco.

but I'd be more than willing to help out by that time.

Cool. I will ping you when things are ready. Could you file a Jira with fix for 0.6?

Thanks

- Hans



Regards,
 Levi

Op 11 feb 2009 om 15:29 heeft Hans Dockter <[email protected]> het volgende geschreven:\


On Feb 10, 2009, at 11:33 AM, Hans Dockter wrote:


On Feb 6, 2009, at 9:37 PM, Levi Hoogenberg wrote:

Hello,

looking at the EclipseClasspath task, I see that there's no way to set the exported attribute of a <classpathentry> to true. I think this would be a nice addition (in fact, I need to do this by hand at the moment). Is this something we can expect in a future version? I'd write a patch, although I'm not sure what the best solution would be (subclassing DefaultModuleDependency? Add a generic map-like property to the dependency?).

It is a good question how to implement this.

Instead of passing file paths to the EclipseClasspath, we should pass a list of Dependency objects. Then one way to provide the functionality we need, would be to let Dependencies provide what we call dynamic properties. That would be the generic map-like approach you are mentioning above. An alternative would be to use the specifications we have introduced in trunk. That way you would define eclipse specific stuff within the Eclipse plugin and not in the general dependency section. You would define an additional specification property in the EclipseClasspath. This spec would define for which dependencies the exported attribute should be set. But from a user's perspective that is probably less convenient. I'm not completely sure yet.

I have thought a bit more about this. A nice solution would be:

1.) A dependency can have dynamic properties.
2.) The classpath file (i.e. jar) must be accessible via the dependency object. 3.) The EclipseClasspath task does not have a list of files but a list of dependency objects.

If 1.) and 2.) is implemented I would ping you, if you are interested in providing a patch for the EclipseClasspath (which would be very nice :)). And I promise that this patch will be applied much faster than your last one.

- Hans





Speaking of dependencies, I have an Ivy dependency on the api configuration of SLF4J. At the moment I'm expressing this as

     compile(':slf4j:1.5.2') {
             dependencyConfigurationMappings.add 'api'
     }

In 0.6 you will be able to do:

compile(':slf4j:1.5.2') {
dependencyConfigurations('api', ...)
}

- Hans



after the syntax mentioned in http://jira.codehaus.org/browse/GRADLE-266 didn't work. Is there a simpler way to express this?

Thanks,
Levi

--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email



--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

 http://xircles.codehaus.org/manage_email



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

  http://xircles.codehaus.org/manage_email



--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to