On Thu, Jul 2, 2020 at 3:01 PM Mike Jumper <[email protected]> wrote:
> I think I've found the cause: > > > https://github.com/apache/guacamole-server/blob/6042222d44d3b501defaff3d51be442fae710f06/src/protocols/rdp/user.c#L131-L145 > > The relevant code looks like this: > > #ifdef ENABLE_COMMON_SSH > guac_rdp_settings* settings = rdp_client->settings; > ... > #endif > > /* Default to using RDPDR uploads (if enabled) */ > if (rdp_client->filesystem != NULL && !settings->disable_upload) > return guac_rdp_upload_file_handler(user, stream, mimetype, > filename); > > > The definition of that variable is within a block that's conditionally > compiled based on whether SSH is available (for the SFTP filesystem). > Lacking SSH support at build time, the variable containing the settings is > not defined within that function. It doesn't *have* to be that way, but > was probably only referenced within that conditional section prior to > introducing support for disabling upload/download. > > Doh! Thanks, Mike. I've entered GUACAMOLE-1122 against this and a pull request for the fix. -Nick >
