On Sat, Sep 5, 2020 at 11:09 PM Mike Jumper <mjum...@apache.org> wrote:
> On Thu, Sep 3, 2020 at 1:49 PM alonp <alon.pe...@cyberark.com> wrote: > >> mjumper wrote >> ... >> Do you know of any reason to avoid handling the >> "CHANNEL_EVENT_WRITE_COMPLETE", and release the stream once it received? >> > > Perhaps, but: > > * Care needs to be taken to ensure we remain compatible with older > releases of FreeRDP that *do* automatically free the wStream. > * If allocating the wStream from FreeRDP's pool would result in the > automatic free behavior, it's probably worth considering leveraging that > wStream pool when it's available. > * Unless there is a reason to not handle the free > within guac_rdp_common_svc_write(), I think that would be a better place. > * If there is a reason to not handle the free within > guac_rdp_common_svc_write() and we cannot rely on automatic free via > FreeRDP's internals, I would guess that the free would also need to be done > for CHANNEL_EVENT_WRITE_CANCELED. > I've opened https://issues.apache.org/jira/browse/GUACAMOLE-1181 for this. - Mike
