On Mon, Dec 28, 2020 at 5:34 PM cspeckrun <[email protected]> wrote:
> ... > I think making GuacamoleHTTPTunnelMap public is a small and low-risk change > that should resolve the module issues and allow alternate server API > implementations. Would a pull request with this change be accepted for the > gaucamole-client project? > I would be very apprehensive about this: Currently, the GuacamoleHTTPTunnelMap class lives hidden and happy as an internal implementation detail of GuacamoleHTTPTunnelServlet. It exists purely for the convenience of GuacamoleHTTPTunnelServlet and how it happens to be implemented *in this current moment*. Should the needs of GuacamoleHTTPTunnelServlet change, then poof - GuacamoleHTTPTunnelMap need not remain the same or even continue to exist., and we have the flexibility to make those changes because it is internal. I don't think changing this would be a good API design decision. On the other hand, if there is a clean way to extract just the request handling core of GuacamoleHTTPTunnelServlet such that it can be reused by any HTTP request handling API, including the provided GuacamoleHTTPTunnelServlet, I think *that* would be a good approach. - Mike
