On Thu, Mar 18, 2021 at 1:29 PM fed <[email protected]> wrote:

> Hi,
>
> Maybe my question was not clear but it's very simple.
>
> With 1.3.0 have you disabled the use of "Guacamole menu" with
> ctrl-alt-shift in some situations after the user login?
>
> Like I said the ctrl-alt-shift command doesn't open any menu when you have
> a message window like the one about a connection not available in the front
> (maybe because it has reached its max connections/max users limits).
>
> If the user has more than one connection on the message you have the
> "Home" button so the user can return to its home but otherwise you can't go
> back to the Home because the "Guacamole menu" doesn't open with
> ctrl-alt-shift.
>
> As I said this behaviour is different from 1.2.0.
>

Hello,

This was not specifically an intentional change between 1.2.0 and 1.3.0.
Running a git bisect between the releases, the change in behavior started
as of the following commit:

commit f3101688e253c7eac136821900c706e40bec1bab
Author: Michael Jumper <[email protected]>
Date:   Sun Nov 1 20:22:52 2020 -0800

    GUACAMOLE-221: Prompt user to provide additional parameters when
"required" instruction is received.


GUACAMOLE-221 dealt with providing an input prompt for the user when
additional parameters are required to complete the connection, such as a
username and password. This prompt uses the same notification subsystem as
the progress notifications you see when starting a connection. Since
handling keyboard events like Ctrl+Alt+Shift would prevent interaction with
normal input fields that may be within the prompt, keyboard handling was
disabled while any notification is displayed:

https://github.com/apache/guacamole-client/blob/bc76efc250bba0155612898233ebfc786e429708/guacamole/src/main/webapp/app/index/controllers/indexController.js#L104-L107
https://github.com/apache/guacamole-client/blob/bc76efc250bba0155612898233ebfc786e429708/guacamole/src/main/webapp/app/index/controllers/indexController.js#L123-L126

If this were narrowed to only disabling keyboard while a notification with
prompts is shown, the menu would resume working as you describe.

Michael Jumper
CEO, Lead Developer
Glyptodon Inc <https://glyp.to/>.

Reply via email to