On Thu, Apr 15, 2021 at 7:17 AM Blackula <[email protected]> wrote:
> BolleoOg wrote > > Are you sure its Guacamole's fault? Did you try to connect with RDP > > directly from another Windows machine? > > > > - Marcel > > Yes, it didn't happen when I was using Guacamoles v1.2.0. > Nothing has changed in Guacamole's RDP support between 1.2.0 and 1.3.0 that could affect handling of colors. If you're seeing a difference between one release and the next, I suspect something may have changed internally within FreeRDP that affects the color conversion process. Within Guacamole, that conversion happens here: https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/rdp/color.c I recall from the early days of the migration to FreeRDP 2 (the 1.1.0 release) that a similar issue occurred when connecting to older Windows machines using 8-bit colors, with the component order of converted pixels being provided as RGB instead of BGR, though this was addressed prior to release. Some of this can be seen in the commit history for the above file: https://github.com/apache/guacamole-server/commits/master/src/protocols/rdp/color.c There's an endianness test there that was required to ensure the color format requested from FreeRDP is correct. More on the background for that check can be found in the documentation for the function performing it: https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/rdp/color.h#L26-L44 Michael Jumper CEO, Lead Developer Glyptodon Inc <https://glyp.to/>.
