On Mon, Jun 21, 2021 at 10:28 AM Mike Jumper <[email protected]> wrote:
> On Mon, Jun 21, 2021 at 6:29 AM Christoph Weber < > [email protected]> wrote: > >> Hi, >> >> I've struggled several hours with an issue which seems to be new in >> 1.3.0. >> >> When I'm using Version 1.3.0 of the mysql jdb auth provider I get an >> >> java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; >> check the manual that corresponds to your MySQL server version for the >> right syntax to use near 'SELECT >> >> The query itself looks fine - but it consists of two select statements, >> which has to be allowed in the jdbc driver with allowMultiQueries =true. >> >> There is code in >> >> >> https://github.com/apache/guacamole-client/blob/master/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java >> >> which hasn't changed for years: >> >> > // Allow use of multiple statements within a single query >> > driverProperties.setProperty("allowMultiQueries", "true"); >> >> but it does not seem to have an effect on the jdbc connection. >> >> Another instance with guacamole 1.1.0 works fine, so I tried to downgrade >> 1.3.0 to 1.2.0 and voila - this one works too. >> >> I could not find any issues on the internet about guacamoles 1.3.0 mysql >> auth provider.Can anybody verify this? >> > > I don't see this with the 1.3.0 release (this would have shown up in > pre-release regression tests), but I do see this with git master. I'll try > a git bisect to see where this started... > > Can you confirm whether you are building from git? > The issue in question is a regression from the work-in-progress vault support currently on git master: https://issues.apache.org/jira/browse/GUACAMOLE-641 >From git bisect: 4dd2a80c84af08b10535743e7e0d19c4994deb5e is the first bad commit commit 4dd2a80c84af08b10535743e7e0d19c4994deb5e Author: Michael Jumper <[email protected]> Date: Tue Aug 25 17:25:27 2020 -0700 GUACAMOLE-641: Log primary sources of configuration information. .../jdbc/DynamicallyAuthenticatedDataSource.java | 76 ++++++++++++++++++++++ .../jdbc/JDBCAuthenticationProviderModule.java | 4 +- .../mysql/MySQLAuthenticationProviderModule.java | 2 - .../PostgreSQLAuthenticationProviderModule.java | 2 - .../SQLServerAuthenticationProviderModule.java | 2 - .../guacamole/GuacamoleServletContextListener.java | 10 ++- 6 files changed, 85 insertions(+), 11 deletions(-) create mode 100644 extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/DynamicallyAuthenticatedDataSource.java If you download the 1.3.0 release, things should be absolutely fine. The issue you're seeing is specific to the under-development code on git. Michael Jumper CEO, Lead Developer Glyptodon Inc <https://glyp.to/>.
