Hey Nick and Mike, Thanks for being my programming heroes. I was spinning my wheels wondering if I should proceed but this repense got me back on track.
I really appreciate you mentioning back porting the pull request in one of the options —I’d never have considered that. With this, I am confident future roadblocks in code will be easier and if not, ChatGPT has my back. Thanks for all your help, you guys are the best! Best, Ryan Sent from my iPhone > On Jan 7, 2023, at 17:01, Nick Couchman <[email protected]> wrote: > > On Thu, Jan 5, 2023 at 6:01 PM Ryan Isenor <[email protected]> wrote: >> >> Thank you Mike for your swift reply. You'll forgive my ignorance in not 100% >> understanding the context of what GUACAMOLE-745 and GUACAMOLE-1553 are >> referring to but let me try to see if I have the right of it. >> >> According to 1553, you advise that the lines of code in question are no >> longer part of the current source on Git. 745 outlines the fixes that were >> done to address the confusion of this issue and its complex nature. While >> the hope is that this may be ready for 1.5.0, it is likely not going to be >> but there is an acceptance that a better solution needs to exist for such >> issues. Finally, the solution in this case, would be to compile Guacamole >> Server 1.4.0 from the current source on Git and not via the download >> packages on the site? If that is indeed the case, might I suggest a >> rewording of the following: If you are looking for the absolute latest >> unreleased code (or extremely old code not archived here), please check our >> git repositories on GitHub. at https://guacamole.apache.org/releases/ the >> reason being that I did indeed go to the Git first but all advisings seem to >> suggest to not use the unreleased code. Pragmatically, I get it but perhaps >> an addendum about OpenSSL 3.0 will help things in the interim? >> >> Do I have the right assessment of things? I am still learning a lot of this, >> so again, forgive my ignorance as I usually like to resolve and solve on my >> own. HAHA! >> > > Not quite - the code was updated, fixing the OpenSSL issue, in the git > repository, and is slated to go into the 1.5.0 release, when we > release that, as part of GUACAMOLE-745. It is already part of the git > branch that will become 1.5.0 (staging/1.5.0). If you want the fix, > now, your options are: > 1) To check out either the staging/1.5.0 or master git branch and > compile from code. > 2) Locate the pull request that fixed the issue and back-port the > patch into 1.4.0. This may be a bit more difficult, since the patch > may not apply cleanly and may take some manual work to get it applied, > and you have to locate the correct pull request and/or commits. > > -Nick > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
