When using Guacamole's on-screen keyboard, on a VNC connection to a Windows host, the Meta key does not seem to have any effect.  We have a pretty homogeneous group of host computers, so for me the attached patch takes care of it; but I suspect that in order to work in all contexts (RDP?  Mac host?) the changes might better be made elsewhere.

Has anyone else experienced the same issue?

The patch is against 1.5.1, but afaict the relevant files don't appear to have changed for some time.

Thanks,

--
-----------------------------------------------------------------------
Konrad Schroder             Box 352143 -or- 115D Fluke Hall, Mason Road
Software Developer and Sys Admin               University of Washington
College of Engineering                          Seattle, WA, 98195, USA
diff -ur 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/dist/app/osk/styles/osk.css
 guacamole-client-1.5.1/guacamole/src/main/frontend/dist/app/osk/styles/osk.css
--- 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/dist/app/osk/styles/osk.css
 2023-05-23 08:07:21.436184978 -0700
+++ 
guacamole-client-1.5.1/guacamole/src/main/frontend/dist/app/osk/styles/osk.css  
    2023-07-06 11:45:52.308280691 -0700
@@ -119,6 +119,9 @@
 /* Active super */
 .guac-keyboard.guac-keyboard-modifier-super .guac-keyboard-key-super,
 
+/* Active meta */
+.guac-keyboard.guac-keyboard-modifier-meta .guac-keyboard-key-meta,
+
 /* Active latin */
 .guac-keyboard.guac-keyboard-modifier-lat .guac-keyboard-key-latin {
     background: #882;
diff -ur 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/dist/layouts/en-us-qwerty.json
 
guacamole-client-1.5.1/guacamole/src/main/frontend/dist/layouts/en-us-qwerty.json
--- 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/dist/layouts/en-us-qwerty.json
      2023-05-23 08:07:21.436184978 -0700
+++ 
guacamole-client-1.5.1/guacamole/src/main/frontend/dist/layouts/en-us-qwerty.json
   2023-07-06 11:45:52.312280668 -0700
@@ -88,9 +88,9 @@
             "keysym"   : 65514
         }],
         "Meta" : [{
-            "title"    : "Meta",
+            "title"    : "Win",
             "modifier" : "meta",
-            "keysym"   : 65511
+            "keysym"   : 65515
         }],
 
         "`" : [
diff -ur 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/src/app/osk/styles/osk.css
 guacamole-client-1.5.1/guacamole/src/main/frontend/src/app/osk/styles/osk.css
--- 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/src/app/osk/styles/osk.css
  2023-03-15 11:03:56.000000000 -0700
+++ 
guacamole-client-1.5.1/guacamole/src/main/frontend/src/app/osk/styles/osk.css   
    2023-07-06 11:45:22.988443261 -0700
@@ -119,6 +119,9 @@
 /* Active super */
 .guac-keyboard.guac-keyboard-modifier-super .guac-keyboard-key-super,
 
+/* Active meta */
+.guac-keyboard.guac-keyboard-modifier-meta .guac-keyboard-key-meta,
+
 /* Active latin */
 .guac-keyboard.guac-keyboard-modifier-lat .guac-keyboard-key-latin {
     background: #882;
diff -ur 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/src/layouts/en-us-qwerty.json
 
guacamole-client-1.5.1/guacamole/src/main/frontend/src/layouts/en-us-qwerty.json
--- 
guacamole-client-1.5.1.dist/guacamole/src/main/frontend/src/layouts/en-us-qwerty.json
       2023-01-13 12:23:54.000000000 -0800
+++ 
guacamole-client-1.5.1/guacamole/src/main/frontend/src/layouts/en-us-qwerty.json
    2023-07-06 11:26:59.818560007 -0700
@@ -88,9 +88,9 @@
             "keysym"   : 65514
         }],
         "Meta" : [{
-            "title"    : "Meta",
+            "title"    : "Win",
             "modifier" : "meta",
-            "keysym"   : 65511
+            "keysym"   : 65515
         }],
 
         "`" : [
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org
For additional commands, e-mail: user-h...@guacamole.apache.org

Reply via email to