Hi Nick, 1) > there may be some extra files in your guacamole-client directory that are getting picked up by RAT Yes thanks. I deleted the extra file and rat errors are resolved.
2) Next I hit this javadocs JAVAHOME error: https://issues.apache.org/jira/browse/MJAVADOC-595 Fixed by adding to pox.xml <configuration> <javadocExecutable>${java.home}/bin/javadoc</javadocExecutable> </configuration> 3) Now maven build fails on guacamole: [INFO] guacamole-common-js ................................ SUCCESS [ 12.186 s] [INFO] guacamole .......................................... FAILURE [01:08 min] openjdk version "17.0.7" 2023-04-18 OpenJDK Runtime Environment (build 17.0.7+7-Debian-1deb12u1) OpenJDK 64-Bit Server VM (build 17.0.7+7-Debian-1deb12u1, mixed mode, sharing) Errors: Jul 07, 2023 1:52:53 PM com.google.javascript.jscomp.LoggerErrorManager println WARNING: all.js:974: WARNING - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag "contant"; ignoring it * @contant ^ Jul 07, 2023 1:52:53 PM com.google.javascript.jscomp.LoggerErrorManager println WARNING: all.js:5943: WARNING - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag "callback"; ignoring it * @callback Guacamole.Event.Target~listener ^ Jul 07, 2023 1:52:53 PM com.google.javascript.jscomp.LoggerErrorManager println WARNING: all.js:9718: WARNING - [JSC_BAD_JSDOC_ANNOTATION] Parse error. illegal use of unknown JSDoc tag "inheritdoc"; ignoring it * @inheritdoc ^ Jul 07, 2023 1:52:53 PM com.google.javascript.jscomp.LoggerErrorManager println WARNING: all.js:14157: WARNING - [JSC_MISPLACED_ANNOTATION] Misplaced function annotation. This JSDoc is not attached to a function node. Are you missing parentheses? element.addEventListener('touchstart', function touchstart(e) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Thanks, Adrian -----Original Message----- From: Nick Couchman <vn...@apache.org> Sent: 06 July 2023 16:14 To: user@guacamole.apache.org Subject: Re: Guacamole client install - fails with org.apache.rat:apache-rat-plugin Error On Thu, Jul 6, 2023 at 10:33 AM Adrian Owen <adrian.o...@eesm.com> wrote: > > Debian 12 + openjdk-17-jdk > > > > git clone https://github.com/apache/guacamole-client.git > > cd guacamole-client > > git checkout 1.5.2 > > mvn package > > > Stops with error: > > > [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check > (validate-licenses) on project guacamole-client: > Too many files with unapproved license: 1 See RAT report in: > /home/nonroot/guacamole-client/target/rat.txt -> [Help 1] It seems like there may be some extra files in your guacamole-client directory that are getting picked up by RAT, which checks for proper license documentation in source code files. My environment is slightly different - CentOS 8 Stream with OpenJDK (11 and 17), but I've tried the steps you posted above and I do not get this error (OpenJDK 17 does not work with 1.5.2 for other reasons). You can also check the rat.txt file mentioned to see which file it is complaining about. -Nick --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscr...@guacamole.apache.org For additional commands, e-mail: user-h...@guacamole.apache.org
