On Thu, Dec 11, 2025 at 4:07 AM Dilip Modi via user
<[email protected]> wrote:
>
> Hello,
>
> I was able to fix this issue using below changes. Can anyone help with review 
> :
>
> diff --git a/guacamole-server/src/terminal/terminal.c 
> b/guacamole-server/src/terminal/terminal.c
>
> index 14d07e0..040aa79 100644
>
> --- a/guacamole-server/src/terminal/terminal.c
>
> +++ b/guacamole-server/src/terminal/terminal.c
>
> @@ -1479,7 +1479,12 @@ static int __guac_terminal_send_key(guac_terminal* 
> term, int keysym, int pressed
>
>              guac_terminal_scroll_display_down(term, term->scroll_offset);
>
>
>
>          /* If alt being held, also send escape character */
>
> -        if (term->mod_alt)
>
> +        /*
>
> +         * If alt is being held, but the keysym is a printable character, do
>
> +         * not send an escape character. This allows AltGr to work correctly.
>
> +         * Otherwise, send ESC for Alt-based shortcuts.
>
> +        */
>
> +        if (term->mod_alt && keysym > 0xFF && (keysym & 0xFFFF0000) != 
> 0x01000000)
>
>              guac_terminal_send_string(term, "\x1B");
>
>
>
>          /* Translate Ctrl+letter to control code */
>
>
> -Dilip
>

Please feel free to create a Jira issue
(https://issues.apache.org/jira/browse/GUACAMOLE) and submit a pull
request for this so that we can review. It looks to be a pretty simple
fix, so hopefully it'll be something we can merge quickly, but I do
want to review the code in context in Github and make sure the changes
are in a place that makes the most sense and that they scale well to
cover other potentially related scenarios.

-Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to