I meant to say why subclasses of List use code for List.class. There is no such handling for subclasses of WritableByteArrayComparable, Writable, etc.
On Sat, Jun 12, 2010 at 9:54 AM, Stack <[email protected]> wrote: > On Fri, Jun 11, 2010 at 10:09 PM, Ted Yu <[email protected]> wrote: > > Why is List treated differently at line 267 in writeClassCode() ? > > Sorry Ted, different to what? > > > > if ( List.class.isAssignableFrom(c)) { > > code = CLASS_TO_CODE.get(List.class); > > } > > I am wondering if the above logic should be applied to other classes in > > CLASS_TO_CODE.keySet(). > > > Please say more. I do not follow. > > Thanks, > St.Ack > > > > > > On Fri, Jun 11, 2010 at 11:14 AM, Stack <[email protected]> wrote: > > > >> On Fri, Jun 11, 2010 at 10:55 AM, Todd Lipcon <[email protected]> > wrote: > >> >> One thing to keep in mind is that the server needs to know about the > >> filter > >> >> you are using (it needs to be in a jar in the classpath). You also > may > >> need > >> >> to add it to HbaseObjectWritable.java so it can be sent across the > RPC > >> >> layer. > >> >> > >> >> > >> > That should only be an efficiency thing, right? > >> > > >> It should just be efficency but its broke currently in that it has to > >> be in place (I filed HBASE-2666 a little while ago). > >> St.Ack > >> > > >
