TRUNK has the same problem. I have made a fix to a JIRA Sindy 2010/11/11 Stack <[email protected]>
> Does TRUNK have the same problem? Do you have a minute to make a fix > and test and apply to a JIRA: > https://issues.apache.org/jira/browse/HBASE? > > Thank you Sindy, > St.Ack > > On Wed, Nov 10, 2010 at 5:42 AM, Sindy <[email protected]> wrote: > > Hi~ > > I've found a problem in > > *org.apache.hadoop.hbase.filter.CompareFilter.doCompare(CompareOp, > > WritableByteArrayComparable, byte[], int, int), * > > *version Hbase 0.20.5* > > followed code maybe exist some mistakes: > > switch (compareOp) { > > case LESS: > > return compareResult <= 0; * // < 0* > > case LESS_OR_EQUAL: > > return compareResult < 0; *// <=0* > > case EQUAL: > > return compareResult != 0; *// ==0* > > case NOT_EQUAL: > > return compareResult == 0; *// !=0* > > case GREATER_OR_EQUAL: > > return compareResult > 0; *// >=0* > > case GREATER: > > return compareResult >= 0; * // >0* > > default: > > throw new RuntimeException("Unknown Compare op " + > > compareOp.name()); > > I have tested the code, the original code can not make the correct > result. > > How do you think of this problem? > > Thanks > > > > -------- > > Sindy > > > -- Sindy Wang
