Sounds right ;) I'll try that, thanks ! On Jan 26, 2013 8:30 PM, "Asaf Mesika" <[email protected]> wrote:
> Yep. > I think it would be faster it you will change the Increment object in the > preIncrement object and add the allCountries column to it. > > When you do it in the PostIncrement method, you will do another Increment > call, thus another :rowLock, write to WAL, etc. > > You can benchmark it easily. > > On 26 בינו 2013, at 20:01, Amit Sela <[email protected]> wrote: > > > The increment has many columns: impressions_country, clicks_country, etc. > > And these counters count events in our system. Since we don't have an > "all > > countries" event, I thought it would be best to do that with a > > RegionObserver (each row has it's own counters so no risk in going > outside > > the region right ?) . > > On Jan 26, 2013 7:15 PM, "Asaf Mesika" <[email protected]> wrote: > > > >> Why not have the Increment object have two columns: one for the country > and > >> one for the allCountries ? > >> > >> Sent from my iPhone > >> > >> On 26 בינו 2013, at 18:54, Infolinks <[email protected]> wrote: > >> > >> Yes, of course. It's an all counter for the specific keyword. > >> > >> ב-26 בינו 2013, בשעה 18:40, Asaf Mesika <[email protected]> כתב/ה: > >> > >> The all counters is on the same row? > >> > >> > >> By the way, did you guys handle the hbase bug that when an increment is > >> > >> sent to region server and fails it still does it but throws an > exception to > >> > >> the client which causes it to do that increment again? > >> > >> > >> > >> Sent from my iPhone > >> > >> > >> On 26 בינו 2013, at 17:32, Amit Sela <[email protected]> wrote: > >> > >> > >> Well, I increment counters where the row key is a keyword and the > qualifier > >> > >> is a country code, and in the post increment region observer I > increment an > >> > >> "all countries" aggregative counter. These counters are divided to > families > >> > >> such as daily, weekly, hourly etc. > >> > >> So I get the family map to know which aggregative counter should I > >> > >> increment, then I piggyback onto the Result the "all countries" current > >> > >> count. > >> > >> On Jan 26, 2013 2:39 AM, "Ted Yu" <[email protected]> wrote: > >> > >> > >> Amit: > >> > >> > >> Can you tell us what operation you perform on the returned family map ? > >> > >> > >> > >> Thanks > >> > >> > >> > >> On Thu, Jan 24, 2013 at 3:37 AM, Amit Sela <[email protected]> wrote: > >> > >> > >> > >> I'm using Increment.getFamilyMap in a postIncrement Observer. > >> > >> > >> I'm running with HBase 0.94.2. > >> > >> > >> > >> Amit. > >> > >> > >> > >> On Thu, Jan 24, 2013 at 4:23 AM, lars hofhansl <[email protected]> > wrote: > >> > >> > >> > >> The reason was that Increment was serialized differently (compared to > >> > >> > >> all > >> > >> > >> other mutations). > >> > >> > >> In trunk that is no longer an issue, since the serialization logic is > >> > >> > >> no > >> > >> > >> longer part of the object to be serialized. > >> > >> > >> > >> > >> -- Lars > >> > >> > >> > >> > >> > >> ________________________________ > >> > >> > >> From: Ted Yu <[email protected]> > >> > >> > >> To: [email protected]; [email protected] > >> > >> > >> Sent: Wednesday, January 23, 2013 10:25 AM > >> > >> > >> Subject: HBASE-7114 Increment does not extend Mutation but probably > >> > >> > >> should > >> > >> > >> > >> Hi, > >> > >> > >> I want to get opinion on whether we should proceed with HBASE-7114 > >> > >> > >> 'Increment does not extend Mutation but probably should' in trunk. > >> > >> > >> > >> Is anyone using Increment.setWriteToWAL or Increment.getFamilyMap ? > >> > >> > >> For Increment.setWriteToWAL, are you using the Increment returned ? > >> > >> > >> > >> Your feedback would be appreciated. > >> > >
