Let's open an issue for this feature? Let's wait for a week, if still no use cases from users, I think we can do some breaking changes on 3.0.0 to open the feature to end users. On 2.x, let's still keep the old classes.
Thanks. Sean Busbey <[email protected]> 于2020年6月8日周一 上午9:39写道： > I think it being labeled IA.Private is incorrect. > > The red guide talks about the feature and directly points folks to the > javadoc of one of the IA.Private classes. > > http://hbase.apache.org/book.html#_constraints > > I'm all for us figuring out what the public surface should be and > correcting this gap, but we need to be mindful as though it were more > public than that annotation claims. > > On Sun, Jun 7, 2020, 19:30 Stack <[email protected]> wrote: > > > If IA.Private, it was for internal use only? Doesn't need a deprecation > to > > change it? > > > > Please speak up if you are using the Constraint feature! > > > > Thanks, > > S > > > > On Sat, Jun 6, 2020 at 12:40 AM 张铎(Duo Zhang) <[email protected]> > > wrote: > > > > > The related classes are marked as IA.Private which means it is not part > > of > > > our public API... > > > > > > That's why I check for shell support, as if there is no shell support, > > then > > > users have no way to make use of it without breaking the > > InterfaceAudience > > > rule... > > > > > > Jesse Yates <[email protected]> 于2020年6月6日周六 上午1:04写道： > > > > > > > Not particularly. Just because there is no shell integration though, > > > > doesn't mean it isn't used - it has been around for 5 years, which > > means > > > > someone likely has picked it up. You should probably ask on the user > > list > > > > and/or do a deprecation cycle to before just removing. > > > > ------------------- > > > > Jesse Yates > > > > @jesse_yates > > > > jesseyates.com <http://jyates.github.com/> > > > > > > > > > > > > On Fri, Jun 5, 2020 at 8:50 AM 张铎(Duo Zhang) <[email protected]> > > > > wrote: > > > > > > > > > Seems only this issue has been finished. > > > > > > > > > > https://issues.apache.org/jira/browse/HBASE-4605 > > > > > > > > > > Which brought in these classes, but the later approach on adding > > shell > > > > > support had been resolved as incomplete. > > > > > > > > > > https://issues.apache.org/jira/browse/HBASE-4879 > > > > > > > > > > So I guess there is no actual use in HBase yet. > > > > > > > > > > Do you still want to finish this feature? > > > > > > > > > > Thanks. > > > > > > > > > > Jesse Yates <[email protected]> 于2020年6月5日周五 下午11:29写道： > > > > > > > > > > > Here is the original JIRA for the constraint work: > > > > > > https://issues.apache.org/jira/browse/HBASE-4999 > > > > > > > > > > > > Its a common DB feature, but not sure if folks actually use it in > > > > HBase. > > > > > > ------------------- > > > > > > Jesse Yates > > > > > > @jesse_yates > > > > > > jesseyates.com <http://jyates.github.com/> > > > > > > > > > > > > > > > > > > On Fri, Jun 5, 2020 at 4:06 AM 张铎(Duo Zhang) < > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > When removing HTableDescriptor on master branch, I found that > it > > > has > > > > > been > > > > > > > referenced by org.apache.hadoop.hbase.constraint package. > > > > > > > > > > > > > > The problem here is that, the API design is to pass in an > > > > > > HTableDescriptor > > > > > > > and modify it directly, but now, TableDescriptor is immutable, > so > > > we > > > > > need > > > > > > > to redesign the API. > > > > > > > > > > > > > > But the problem is that, all the classes are marked as > > IA.Private, > > > > and > > > > > > the > > > > > > > only references to these classes are in the test code. And I > can > > > not > > > > > find > > > > > > > any useful information through the git log, the earliest one is > > > > > > > > > > > > > > commit 390f32d79fd0c0464fcab008150ad182f4c0abef > > > > > > > Author: Michael Stack <[email protected]> > > > > > > > Date: Sat May 26 05:56:04 2012 +0000 > > > > > > > > > > > > > > HBASE-4336 Convert source tree into maven modules > > > > > > > > > > > > > > git-svn-id: > > > https://svn.apache.org/repos/asf/hbase/trunk@1342856 > > > > > > > 13f79535-47bb-0310-9956-ffa450edef68 > > > > > > > < > > > > > > > > > > > > > > > > > > > > > https://svn.apache.org/repos/asf/hbase/trunk@134285613f79535-47bb-0310-9956-ffa450edef68 > > > > > > > > > > > > > > > > > > > > > Does anyone still use this feature? Or does anyone have some > > > > background > > > > > > on > > > > > > > how this feature works? > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > > > > > > > > >
