This is a behavior change, it makes non admin users can clone snapshot. For me I do not think we should include changes like this in a patch release, unless it is considered as a critical bug which must be fixed.
Thanks. Szabolcs Bukros <szabo...@cloudera.com.invalid> 于2022年11月30日周三 00:06写道： > > This should not break any existing use case so I see no reason to not add > this to branch-2.5 and > branch-2.4. > > On Thu, Nov 24, 2022 at 3:03 AM 张铎(Duo Zhang) <palomino...@gmail.com> wrote: > > > I'm OK with this change. > > > > But maybe we still need to determine which branches we can apply this > > change to? Is it OK to include this change for branch-2.5 and > > branch-2.4? > > > > Tak Lon (Stephen) Wu <tak...@apache.org> 于2022年11月22日周二 06:31写道： > > > > > > FYI the PR is https://github.com/apache/hbase/pull/4885 and > > > https://issues.apache.org/jira/browse/HBASE-27493. > > > > > > the proposal seems to be, should we allow cloning snapshot to any > > > namespace if they're not the global admin. > > > > > > logically, it should be fine because they're the admin for the > > > namespace, and should be able to do whatever within that namespace. > > > > > > Thanks, > > > Stephen > > > > > > > > > On Mon, Nov 21, 2022 at 11:38 AM Szabolcs Bukros > > > <szabo...@cloudera.com.invalid> wrote: > > > > > > > > Hi Everyone, > > > > > > > > Creating a snapshot requires table admin permissions. But cloning it > > > > requires global admin permissions unless the user owns the snapshot and > > > > wants to recreate the original table the snapshot was based on using > > the > > > > same table name. This puts unnecessary load on the few users having > > global > > > > admin permissions on the cluster. I would like to relax this rule a > > bit and > > > > allow the owner of the snapshot to clone it into any namespace where > > they > > > > have admin permissions regardless of the table name used. > > > > > > > > Please let me know what you think about this proposal. And if you find > > it > > > > acceptable which branch do you think this could land on. > > > > > > > > Thanks, > > > > Szabolcs Bukros > >
