Hi Dan,

I was just about to let you know about it ... but you beat me to it.

It's a first cut that can be improved on.   My aim was to provide a POC
to satisfy your requirement (as I understood it) without breaking
backward compat.

Have a look at the trader example (TraderSteps has a converter method
annotated with @AsParameterConverter).

Essentially, I've decorated the existing ExamplesTable#getRow(int)
functionality with another ExamplesTable#getRowAsParameters(int) using
the some of the same ideas that you had in your contribution, i.e.
having the Row#valueAs(String,Class) as the access point for parameter
value conversion.

The method getRowAsParameters(int) could be moved to a separate class
(say ParametersTable, either a subclass or a decorator of ExamplesTable)
but I would think it's actually simpler to leave in the same class. 
It's optional functionality and users can decide to make use of it or not.

Cheers

On 06/12/2010 10:36, Dan Godfrey wrote:
> Hi Mauro,
>
> I saw your commit for this. Have you finished yet? I have some extras
> on top of the basic implementation, but will hold off patching if
> you're going to add some more.
>
> Dan.
>
>
>

Reply via email to