upperbound  is 30.

as each pack_id which is parent has 3 subpackages only

that's why added j<=3

all i want is

1,1 =1,1,2=2,1,3=3
2,4=4,2,5=5,2,6=6
3,7=7,3,8=8,3,9=9
so on ...

Am not getting it right ..my brain is just going bleak ....

On Tue, Dec 6, 2011 at 11:58 AM, Felix Frank <[email protected]> wrote:

> Hi,
>
> On 12/06/2011 11:16 AM, Shaba K wrote:
> >
> > all i want is
>
> OK, then this
>
> > for(int j=i;j<=3;j++)
>
> is wrong. Why j<=3. It doesn't make any sense. What's your upper bound
> for the subpackage ID?
>
> You should refactor the whole thing.
>
> 1. replace i and j by meaningful iterator names like pkg_id and sub_pkg_id
> 2. get your String concatenation out of the addArgument call
>
> Insert lines like
> String index1 = "[" + vars.get(...) + "]";
> String index2 = "[" + vars.get(...) + "]";
> String param  = "package" + index1 + index2;
> String value = ...;
> then
> addArgument(param, value);
>
> If possible, add debug output in some form (although I haven't managed
> to figure out a good way to do this yet).
>
> HTH,
> Felix
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to