Hello Andrey, I am not the only decider regarding its integration, but in my opinion current patch still needs more work so it seems to me it would be premature to include it in 2.9 as is:
- Undo is only enabled on Tree elements, so regarding ergonomics it will be strange for users (I tried to use it for a while to do some tests and I must say I reverted it) that CTRL+Z does not work in fields, inputs , select boxes ... - As I already said, it also consumes much memory and CPU as the whole tree is saved each time a new element is added. - Regarding "Marketing" presentation of this feature, it seems weird to me to say "undo is now supported" in 2.9 while in fact it is only very partial. In my opinion introducing it as is could kind of hurt "quality" perception of JMeter which is important for us I think and for Apache organisation. - Undo needs more work to meet minimum level of acceptance and UndoManager of Swing should be used I think. Maybe current patch could be reworked to use it But again, many thanks for this contribution which is a good basis , but it is true it would need some time to be fully implemented. Regards Philippe On Fri, Jan 4, 2013 at 11:24 AM, apc <[email protected]> wrote: > Philippe, is there a chance to have this patch applied in 2.9? > https://issues.apache.org/bugzilla/show_bug.cgi?id=42248 > > I suppose even short history length will make users happy. Also there can > be > an option in jmeter.properties to change history length... > > > > ----- > -- > Andrey Pohilko > JP@GC Maintainer > -- > View this message in context: > http://jmeter.512774.n5.nabble.com/CTRL-Z-as-undo-tp4848249p5715712.html > Sent from the JMeter - User mailing list archive at Nabble.com. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Cordialement. Philippe Mouawad.
