Not sure why those wraps are there to be honest. I noticed that too while linking it. In my local builds there are no wraps.
As for the core/compendium stuff that was just me copying what Brett had done for the felix based tests. I will look into removing them. Of course if you want to take a look, please feel free. Most people in these parts seem to show an awesome unwillingness to look at any non-Maven builds :) On May 20, 2015 3:52 PM, "cschneider [via Karaf]" < [email protected]> wrote: > Very cool to see you produce a karaf feature file. I can add it to the > org.apache.karaf.features.repos.cfg so people have a nice shortcut to > install it. > I will wait till it stabilizes a bit though. > > I already have some feedback for the current version. > The first thing is that you should avoid the wrap: protocol. It is only > the last resort to install a bundle. For example we had a customer who > wanted to sign bundles and enforce that only signed bundles are loaded. > This does not work with wrap. For most cases we can already find jars > that are bundles. > Another issue is that you should not install org.osgi.core or > org.osgi.compendium. Core packages should already be provided by the > framework and compendium packages should be either embedded or installed > as a jar that only contains the spec you use. The reason is that > installing unnecessary packages from the spec increases chances that > other bundles bind to the wrong package. > If you want I can check out the source and try to provide a patch with > improvements for the feature file. > > Christian > > On 20.05.2015 15:24, sebersole wrote: > > > For what it is worth, in 5.0 I also started publishing a Karaf features > file > > from the hibernate-osgi build. Same maven coordinates as > hibernate-osgi, > > but using the type (or is it classifier? Maven terms are always > confusing > > to me) "karaf". So far only snaspshots have it being published: > > > http://snapshots.jboss.org/maven2/org/hibernate/hibernate-osgi/5.0.0-SNAPSHOT/hibernate-osgi-5.0.0-20150519.200809-133-karaf.xml > > > > > > > > -- > > View this message in context: > http://karaf.922171.n3.nabble.com/Hibernate-OSGi-Integration-tp4040190p4040520.html > > Sent from the Karaf - User mailing list archive at Nabble.com. > > > -- > Christian Schneider > http://www.liquid-reality.de > > Open Source Architect > http://www.talend.com > > > > ------------------------------ > If you reply to this email, your message will be added to the discussion > below: > > http://karaf.922171.n3.nabble.com/Hibernate-OSGi-Integration-tp4040190p4040524.html > To unsubscribe from Hibernate OSGi Integration, click here > <http://karaf.922171.n3.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=4040190&code=c3RldmVAaGliZXJuYXRlLm9yZ3w0MDQwMTkwfDEzODcxNjU0NQ==> > . > NAML > <http://karaf.922171.n3.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://karaf.922171.n3.nabble.com/Hibernate-OSGi-Integration-tp4040190p4040526.html Sent from the Karaf - User mailing list archive at Nabble.com.
