Good catch ;)

Regards
JB

On 12/04/2015 01:28 PM, Benson Margulies wrote:
I found the source of all of this.

In a feature.xml, I stupidly wrote:

<feature version="${project.version}" prerequisite="false"
dependency="false">rosapi-common</feature>

That ran me into the other JIRA initially, and into other problems when
I switched to my osgiVersion, since I was specifying that we use the
version of the depending feature for the depended-on feature.


On Thu, Dec 3, 2015 at 4:14 PM, Benson Margulies <[email protected]
<mailto:[email protected]>> wrote:



    On Thu, Dec 3, 2015 at 2:46 PM, Jean-Baptiste Onofré
    <[email protected] <mailto:[email protected]>> wrote:

        Let me check,  and fix (you should really use features XML as
        template with the maven plugin instead of direct generation).


    JB, that's just what I did. I captured what the generator generated
    in order to give you a test case.


        Regards
        JB

        On 12/03/2015 08:22 PM, Benson Margulies wrote:

            Then we have two bugs, because the manifestation when I switched
            everything to full OSGi versions (as shown by the testcase)
            is different.


            On Thu, Dec 3, 2015 at 2:19 PM, Oliver Lietz
            <[email protected] <mailto:[email protected]>
            <mailto:[email protected]
            <mailto:[email protected]>>> wrote:

                 On Thursday 03 December 2015 15:00:45 Jean-Baptiste
            Onofré wrote:
                 > Your version doesn't look good (0.7.105-SNAPSHOT
            instead of
                 > 0.7.105.SNAPSHOT).

                 KARAF-4105

                 O.

                  > Regards
                  > JB
                  >
                  > On 12/03/2015 02:52 PM, Benson Margulies wrote:
                  > > My assembly builds that worked in 4.0.2 don't work
            in 4.0.3.
                  > >
                  > > The error is:
                  > >
                  > > [ERROR] Failed to execute goal
                  > >
            org.apache.karaf.tooling:karaf-maven-plugin:4.0.3:assembly
                  > > (default-assembly) on project
            rosapi-assembly-min-test: Unable to
                  > > build assembly: Could not find matching feature for
                  > > rosapi-common/0.7.105-SNAPSHOT -> [Help 1]
                  > >
                  > > This comes from a pom which says:
                  > >   <feature>rosapi-common</feature>
                  > >
                  > > in the list of boot features.
                  > >
                  > > The rosapi-common feature exists in a feature.xml:
                  > >          <dependency>
                  > >
                  > >              <groupId>${project.groupId}</groupId>
                  > >              <artifactId>rosapi-features</artifactId>
                  > >              <version>${project.version}</version>
                  > >              <classifier>features</classifier>
                  > >              <type>xml</type>
                  > >              <scope>runtime</scope>
                  > >
                  > >          </dependency>
                  > >
                  > > Which contains:
                  > >      <feature name="rosapi-common"
            description="rosapi-common"
                  > >
                  > > version="0.7.105.SNAPSHOT">
                  > >
                  > >          <details>Code in common for Rosette API
            Web Service
                 1.5</details>
                  > >          <feature prerequisite="false"
                  > >
                  > > dependency="false">bean-validation-support</feature>
                  > >
                  > >

            <bundle>mvn:com.basistech.ws/rosapi-common/0.7.105-SNAPSHOT
            <http://com.basistech.ws/rosapi-common/0.7.105-SNAPSHOT>

            <http://com.basistech.ws/rosapi-common/0.7.105-SNAPSHOT></bund
                  > >          le>
                  > >
                  > >         ...
                  > >
                  > >      </feature>
                  > >
                  > > Note the - in the version in the error message,
            but the . in the
                  > > version in the feature.xml. It's a generated
            feature.xml via the
                  > > karaf-maven-plugin. Is there a way to write the
            version in the pom
                  > > boot list to get around this?



        --
        Jean-Baptiste Onofré
        [email protected] <mailto:[email protected]>
        http://blog.nanthrax.net
        Talend - http://www.talend.com




--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com

Reply via email to