Hey
Yes I didn't push yet (the changes are on a local branch).
Regards JB
Sent from my Samsung device
-------- Original message --------
From: Sergiy Shyrkov <[email protected]>
Date: 28/06/2016 13:50 (GMT+01:00)
To: [email protected]
Subject: Re: Karaf Cellar - ClusterBundleEvent.getSourceNode() is null in most
of the cases
Hello JB,
thank you for the reply!
I am not sure, how it was fixed.
I still see that the CellarBundleMBeanImpl
(https://github.com/apache/karaf-cellar/blob/master/bundle/src/main/java/org/apache/karaf/cellar/bundle/management/internal/CellarBundleMBeanImpl.java
) does not set source node for the ClusterBundleEvent, but only the source
group.
Was it fixed somewhere else perhaps?
Kind regards
Sergiy
On Mon, 27 Jun 2016 20:27:48 +0200, Jean-Baptiste Onofré <[email protected]>
wrote:
> Hi Sergiy,
>
> I already fixed that for next Cellar 4.0.1. The same happens in the
> features and configs.
>
> Regards
> JB
>
> On 06/27/2016 05:42 PM, Sergiy Shyrkov wrote:
>> Hello guys,
>>
>> we are implementing some code around Karaf Cellar (an EventHandler),
>> which is using ClusterBundleEvent.
>> In most of the cases the ClusterBundleEvent.getSourceNode() is null, so
>> in case of bundle operations via
>> org.apache.karaf.cellar.bundle.management.internal.CellarBundleMBeanImpl
>> we are not able to distinguish between "local" and "external" events
>> (i.e. triggered from the same node or from other cluster nodes).
>>
>> The source node is only set in:
>> - BundleSynchronizer.push()
>> - LocalBundleListener.bundleChanged()
>>
>> but not in the CellarBundleMBeanImpl and 4 corresponding shell commands.
>>
>> Is there any reason of not setting that node info in the above mentioned
>> cases?
>> If no, may I submit a pull request with the changes?
>>
>> Thank you in advance!
>>
>> Kind regards
>> Sergiy
>>
>>
>
--
Sergiy Shyrkov
Software Architect
Jahia Solutions Group SA
http://www.jahia.com
