Sure! You can start by filing a Jira and then attach a patch to it. Glad it worked !
Best, Sandeep On Wed, Jul 25, 2018 at 3:58 PM Watson, Billy <billy.wat...@disney.com> wrote: > I built an extension that does this and it seems to work. Should I open > source my extension or submit a patch? > > > > > > > > *Billy Watson* > > > > > > *From: *Sandeep Moré <moresand...@gmail.com> > *Reply-To: *"user@knox.apache.org" <user@knox.apache.org> > *Date: *Wednesday, July 25, 2018 at 3:54 PM > *To: *"user@knox.apache.org" <user@knox.apache.org> > *Subject: *Re: Supporting Hal+JSON rewrites > > > > Hello Billy, > > > > I don't think Knox supports application/hal+json content-type (seems to me > that way). I don't know much about application/hal+json, but structurally > it looks like JSON, you can try adding it [1] to the supported content > types for JsonUrlRewriteStreamFilter. > > > > Best, > > Sandeep > > > > [1] > https://github.com/apache/knox/blob/92e2ec59a5940a9e7c67ec5cd29044f811dee40a/gateway-provider-rewrite/src/main/java/org/apache/knox/gateway/filter/rewrite/impl/json/JsonUrlRewriteStreamFilter.java#L32 > > > > > > > > On Wed, Jul 25, 2018 at 1:31 PM Watson, Billy <billy.wat...@disney.com> > wrote: > > Hello, > > > > TL;DR > > 1. Am I correct in saying that knox will not rewrite > application/hal+json content-type responses? > 2. If so, can I write an extension to knox to make it do so? > 3. And if so, where do I begin? > > > > I have a GUI I’m putting behind knox and part of that application returns > application/hal+json responses (as opposed to application/json). Knox is > working for everything except those APIs that return the > application/hal+json responses: the GUI, comes up, I can navigate across > pages, etc.) but of course some data is missing. > > > > How can I get knox to rewrite the special JSON? I have tried: > > > > <content type="*/*"> > > <content type="application/*"> > > <content type="application/json"> > > > > I see that knox supports extensions and I’ve seen the code for the > JsonUrlRewriteStreamFilter, but other than that I don’t know where to begin. > > > > > > > > > > Thanks, > > > > *Billy Watson* > > > >
