All, I fixed https://issues.apache.org/jira/browse/KNOX-2684 and now waiting for reviews. Once it's merged to master I'll cherry-pick it to our release branch and kick-off RC2.
Sandor On Fri, Oct 22, 2021 at 5:17 PM larry mccay <lmc...@apache.org> wrote: > Agreed - that's a blocker. > > > On Fri, Oct 22, 2021 at 8:38 AM Sandeep Moré <moresand...@gmail.com> > wrote: > > > Sounds great, I’ll file a JIRA with the details. > > > > On Fri, Oct 22, 2021 at 8:26 AM Sandor Molnar > <smol...@cloudera.com.invalid> > > wrote: > > > >> Thanks, Sandeep! > >> > >> I'd call this issue a release blocker and we need to file a JIRA to fix > >> this and kick-off a new release candidate. > >> > >> Any objection? > >> > >> On Fri, Oct 22, 2021 at 2:02 PM Sandeep Moré <moresand...@gmail.com> > >> wrote: > >> > >> > **Update: vote -1 > >> > I discovered a bug while testing the logout feature so I need to > >> withdraw > >> > my vote. > >> > This is the error I see when I click the logout button > >> > > >> > ------ > >> > HTTP ERROR 500 javax.servlet.ServletException: > >> > org.apache.jasper.JasperException: Unable to compile class for JSP: An > >> > error occurred at line: [155] in the jsp file: [/logout.jsp] response > >> > cannot be resolved 152: } catch (Exception e) { 153: return ""; 154: } > >> 155: > >> > response.setStatus(HttpServletResponse.SC_TEMPORARY_REDIRECT); 156: > >> > response.setHeader("Location", globalLogoutPageURL); 157: return; 158: > >> %> > >> > An error occurred at line: [156] in the jsp file: [/logout.jsp] > response > >> > cannot be resolved 153: return ""; 154: } 155: > >> > response.setStatus(HttpServletResponse.SC_TEMPORARY_REDIRECT); 156: > >> > response.setHeader("Location", globalLogoutPageURL); 157: return; 158: > >> %> > >> > 159: </head> An error occurred at line: [156] in the jsp file: > >> > [/logout.jsp] globalLogoutPageURL cannot be resolved to a variable > 153: > >> > return ""; 154: } 155: > >> > response.setStatus(HttpServletResponse.SC_TEMPORARY_REDIRECT); 156: > >> > response.setHeader("Location", globalLogoutPageURL); 157: return; 158: > >> %> > >> > 159: </head> An error occurred at line: [157] in the jsp file: > >> > [/logout.jsp] This method must return a result of type String 154: } > >> 155: > >> > response.setStatus(HttpServletResponse.SC_TEMPORARY_REDIRECT); 156: > >> > response.setHeader("Location", globalLogoutPageURL); 157: return; 158: > >> %> > >> > 159: </head> 160: An error occurred at line: [157] in the jsp file: > >> > [/logout.jsp] Syntax error, insert "}" to complete MethodBody 154: } > >> 155: > >> > response.setStatus(HttpServletResponse.SC_TEMPORARY_REDIRECT); 156: > >> > response.setHeader("Location", globalLogoutPageURL); 1 > >> > > >> > On Thu, Oct 21, 2021 at 3:32 PM Sandeep Moré <moresand...@gmail.com> > >> > wrote: > >> > > >> >> Thank you Sandor! and apologies for the delay. > >> >> Here is my +1 > >> >> > >> >> --- > >> >> * Downloaded and built from source > >> >> * Checked LICENSE and NOTICE files > >> >> * Verified GPG/SHA signatures for Knox source, Knox and Knoxshell > >> release > >> >> packages > >> >> * Installed pseudo-distributed instance (Mac OS X ) > >> >> * Checked KnoxShell samples > >> >> > >> >> Thanks, > >> >> Sandeep > >> >> > >> >> On Fri, Oct 15, 2021 at 4:40 PM Sandor Molnar <smol...@cloudera.com> > >> >> wrote: > >> >> > >> >>> Hi folks! > >> >>> > >> >>> Release candidate #1 for the Apache Knox 1.6.0 release is available > >> at: > >> >>> > >> >>> https://dist.apache.org/repos/dist/dev/knox/knox-1.6.0/ > >> >>> > >> >>> The release candidate is a zip archive of the sources in: > >> >>> > >> >>> https://gitbox.apache.org/repos/asf/knox.git > >> >>> Branch v1.6.0 (git checkout -b v1.6.0) > >> >>> > >> >>> The KEYS file for signature validation is available at: > >> >>> https://dist.apache.org/repos/dist/release/knox/KEYS > >> >>> > >> >>> KnoxShell User Guide: > >> >>> http://knox.apache.org/books/knox-1-6-0/knoxshell_user_guide.html > >> >>> > >> >>> Gateway User Guide: > >> >>> http://knox.apache.org/books/knox-1-6-0/user-guide.html > >> >>> > >> >>> Dev Guide: > >> >>> http://knox.apache.org/books/knox-1-6-0/dev-guide.html > >> >>> > >> >>> Please vote on releasing this package as Apache Knox 1.6.0. > >> >>> The vote is open for the next 96 hours and passes if a majority of > at > >> >>> least three +1 Apache Knox PMC votes are cast. > >> >>> > >> >>> [ ] +1 Release this package as Apache Knox 1.6.0 > >> >>> [ ] -1 Do not release this package because... > >> >>> > >> >>> Thanks, > >> >>> Sandor > >> >>> > >> >> > >> > > >