Guys, I can change that today - any objections from anyone? Cheers,
/peter neubauer COO and Sales, Neo Technology GTalk: neubauer.peter Skype peter.neubauer Phone +46 704 106975 LinkedIn http://www.linkedin.com/in/neubauer Twitter http://twitter.com/peterneubauer http://www.neo4j.org - Your high performance graph database. http://www.thoughtmade.com - Scandinavia's coolest Bring-a-Thing party. On Tue, May 25, 2010 at 10:41 PM, Andreas Kollegger <[email protected]> wrote: > That makes sense. I had forgotten that many (most, all?) of the impl classes > in Neo are exposed rather than private. > > Good work straightening that out. > > -Andreas > > On May 25, 2010, at 4:32 PM, David Allen wrote: > >> I actually had to remove the Private-Package directive (and the ! for >> kernel.impl) because neo4j-index requires interfaces and classes in the >> impl.batchinsert and impl.cache packages of kernel. :-( >> >> >> >> David >> >> >> On May 25, 2010, at 12:30 PM, David Allen wrote: >> >>> Thanks for the quick response Andreas. There are some packages defined >>> below that do not exist, so it seemed to fail again. I changed to the >>> following and it seems to work so far: >>> >>> Export-Package: >>> ${bundle.namespace}.graphdb.*;version="${pom.version}",!${bundle.namespace}.kernel.impl.*,${bundle.namespace}.kernel.*;version="${pom.version}",${bundle.namespace}.commons.*;version="${pom.version}" >>> Private-Package: ${bundle.namespace}.kernel.impl.* >>> >>> Cheers! >>> David >>> >>> On May 25, 2010, at 11:21 AM, Andreas Kollegger wrote: >>> >>>> Hi David, >>>> >>>> Y'know I never even got around to switching to the 1.0 release, so I'm a >>>> little behind. But, after updating the source it does look like the kernel >>>> component has some bad bnd instructions. The parent pom assumes >>>> ${bundle.namespace} is the top-level package, and that >>>> ${bundle.namespace}.impl is private internal implementation code. However, >>>> kernel has three top-level packages in the bundle: org.neo4j.graphdb, >>>> org.neo4j.kernel and org.neo4j.commons. >>>> >>>> So, the instructions have to be revised to reflect that. There's a file >>>> called osgi.bnd in the source which can be used to override the default >>>> pom plugin settings. Try adding this at the top of the file, just before >>>> the Import-Package instruction... >>>> >>>> Export-Package: >>>> !${bundle.namespace}.graphdb.impl.*,${bundle.namespace}.graphdb.*;version="${pom.version}",!${bundle.namespace}.kernel.impl.*,${bundle.namespace}.kernel.*;version="${pom.version}",!${bundle.namespace}.commons.impl.*,${bundle.namespace}.commons.*;version="${pom.version}" >>>> Private-Package: >>>> ${bundle.namespace}.graphdb.impl.*,${bundle.namespace}.kernel.impl.*,${bundle.namespace}.commons.impl.* >>>> >>>> >>>> Best, >>>> Andreas >>>> >>>> ps. I would check these changes into trunk, but I seem to have forgotten >>>> my credentials. Would one of the active committers mind trying the above? >>>> Thanks. >>>> >>>> On May 25, 2010, at 1:46 PM, David Allen wrote: >>>> >>>>> Hey Neo Community - >>>>> >>>>> I recently moved to the 1.1-SNAPSHOT to test reads w/o Tx, but the kernel >>>>> bundle doesn't seem export any packages. The index bundle seems to be >>>>> fine still, but can't find the org.neo4j.graphdb package which should be >>>>> exported from the kernel bundle. Poking around I can't really find a >>>>> change that would have mattered, but maybe someone else with more OSGI >>>>> experience can help out? >>>>> >>>>> Also, does anyone know of a source for a lucene 2.9.2 osgi bundle that >>>>> would be compatible with the index code? I can wrap my own, but was just >>>>> wondering. >>>>> >>>>> Thanks, >>>>> David Allen >>>>> _______________________________________________ >>>>> Neo4j mailing list >>>>> [email protected] >>>>> https://lists.neo4j.org/mailman/listinfo/user >>>> >>>> _______________________________________________ >>>> Neo4j mailing list >>>> [email protected] >>>> https://lists.neo4j.org/mailman/listinfo/user >>> >> >> _______________________________________________ >> Neo4j mailing list >> [email protected] >> https://lists.neo4j.org/mailman/listinfo/user > > _______________________________________________ > Neo4j mailing list > [email protected] > https://lists.neo4j.org/mailman/listinfo/user > _______________________________________________ Neo4j mailing list [email protected] https://lists.neo4j.org/mailman/listinfo/user
