No problem, Alex. I spotted what looks like two more typos afterwards in the
request and response to GET /batches/{batchId}/log at
https://github.com/apache/incubator-livy/blob/master/docs/rest-api.md#get-batchesbatchidlog
Request – types for ‘from’ and ‘size’ should be int rather than ‘Offset’
Response - types for ‘id’, ‘from’ and ‘size’ should be int rather than ‘id’
From: Alex Bozarth [mailto:[email protected]]
Sent: 24 October 2017 23:29
To: [email protected]
Subject: EXT: Re: Typo in REST API (GET /sessions response body) docs?
Thanks Lucas, nice catch. I'm surprised that typo has lasted so long without
being found.
Alex Bozarth
Software Engineer
Spark Technology Center
________________________________
E-mail: [email protected]<mailto:[email protected]>
GitHub: github.com/ajbozarth<https://github.com/ajbozarth>
505 Howard Street
San Francisco, CA 94105
United States
[Inactive hide details for "Partridge, Lucas (GE Aviation)" ---10/23/2017
07:37:39 AM---In https://urldefense.proofpoint.com/v2/]"Partridge, Lucas (GE
Aviation)" ---10/23/2017 07:37:39 AM---In
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dlivy_blob_mast
From: "Partridge, Lucas (GE Aviation)"
<[email protected]<mailto:[email protected]>>
To: "[email protected]<mailto:[email protected]>"
<[email protected]<mailto:[email protected]>>
Date: 10/23/2017 07:37 AM
Subject: Typo in REST API (GET /sessions response body) docs?
________________________________
In
https://github.com/apache/incubator-livy/blob/master/docs/rest-api.md#response-body<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dlivy_blob_master_docs_rest-2Dapi.md-23response-2Dbody&d=DwMFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=S1_S7Dymu4ZL6g7L21O78VQZ53vEnAyZ-cx37DPYDyo&m=dob-sH8OteD1E91fg0rXp60KQS0Cp-RheMMAvIaZLvs&s=uLDlCOBOj-IO4jFCW3NNmiN_LozowiV_TXZ68vvFSgs&e=>
– shouldn’t ‘size’ be replaced with ‘total’? Put it this way, if I use ‘total’
a Java client works, whereas it doesn’t if I use ‘size’.
This change would also make the response body consistence with that for GET
/batches:
https://github.com/apache/incubator-livy/blob/master/docs/rest-api.md#response-body-9<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dlivy_blob_master_docs_rest-2Dapi.md-23response-2Dbody-2D9&d=DwMFAg&c=jf_iaSHvJObTbx-siA1ZOg&r=S1_S7Dymu4ZL6g7L21O78VQZ53vEnAyZ-cx37DPYDyo&m=dob-sH8OteD1E91fg0rXp60KQS0Cp-RheMMAvIaZLvs&s=r6IrhsRLPxUGa314rLrLFD-bsxFNgE_OpTBXaoZEkMU&e=>
(although perhaps that should use ‘batches’ rather than ‘sessions’?!).
