Thank you for your feedback, Ida, see my answers/comments inline
Ida de Groot wrote:
Hi, This is really good news, thanks. It works for me and it also seems to have solved MNGECLIPSE-941 (build broke on platform specific fragments) and MNGECLIPSE-949 (eclipse-update-site breaks on "directory based bundle"), so I will close those issues. I did notice some things: - The .qualifier version extension is not replaced in filenames in the product.
Right now .qualifier version expansion needs to be configured/enabled explicitly, see [1] for relatively detailed explanation, but in nutshells, you need to define buildNumber property either externally or using one of existing plugins.
- Our product was in a plugin project that also containes code that other plugins depended on. So it had to be build before some other plugins. This caused a java.lang.NullPointerException in org.codehaus.tycho.eclipsepackaging.ProductExportMojo.copyToFile(Product ExportMojo.java:379). In the feature based product the error was a bit more descriptive, it said "The source file isn't defined.". It was solved by putting the product build (and the .product file) in the feature project, which is build after all included plugins are build, as Marvin suggested for the feature based product anyway. Does make sense, but it is a restriction that is not in the pde build, so it is good to be aware of it.
Next DEV build will have new eclipse-application packaging type. This is the only way to guarantee proper build order. See also MNGECLIPSE-535.
- In the example on http://docs.codehaus.org/display/M2ECLIPSE/Tycho+Product+Export it would be good to include an id for the execution, otherwise it will not get executed if you also define a timestamp execution in the parent pom. <execution> <phase>package</phase> ---> <id>product-export</id> <goals> <goal>product-export</goal> </goals> <configuration> ... </configuration> </execution>
Done. FYI, there was a bug in earlier maven 3.0 builds that did not like specific execution ids, I guess that bug is fixed now.
And we have some more wishes on the list: - We need to do a multi-platform build, this is now possible by running the build 4 times with different osgi.* arguments, which takes a long time). It would be nice if this could be done by configuration of the maven-osgi-packaging-plugin.
Is it the same problem you reported in MNGECLIPSE-941? If this is a different problem, can you please open new JIRA and provide sample project and expected output.
Also, it'd be interesting to know how (or if) PDE/Build works for multiple target platforms.
- We do have a product configuration that includes splash, about and other branding information. On these properties, the logging responds with the following warnings: [WARNING] Tycho doesn't handle 'aboutInfo' property. [WARNING] Tycho doesn't handle 'windowImages' property. [WARNING] Tycho doesn't handle 'splash' property. [WARNING] Tycho doesn't handle 'vm' property.
Can you please open JIRA enhancement request for this? Provide sample project if you have one handy, but we should be able to figure out details from the docs.
- It would be really convenient if the build would be possible per plugin project, so tycho looks for included plugins in the maven repository too. Is that anywhere on the list?
Improving artifact repositories support is something I work on right now. Bulk of maven repository support is already in SVN and we're trying to make it work for the next DEV build. I am not sure this will allow per-plugin project builds, but it will certainly be possible to split one big monolithic build into a number of smaller ones and share binary plugins and feature via maven repository.
This brings up another question. Are you using P2 repository support prototype included in the current DEV build? New target platform management code is quite different and only supports local eclipse installations and maven repositories at the moment. I was planning to defer P2 support for later builds and wonder if this is going to be a deal breaker.
[1] http://docs.codehaus.org/display/M2ECLIPSE/Tycho+user+docs#Tychouserdocs-Eclipseversionsandtimestamps%3B\SNAPSHOT%2F.qualifierversions
--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
