Baptiste,

I committed fix into trunk. Version info is now added after the project name.
 See http://jira.codehaus.org/browse/MNGECLIPSE-1073

Though recommended practice is to keep project names derived from the artifactId (e.g. [artifactId], [groupId].[artifactId], [artifactId]-[version] or [artifactId]-someSuffix).

In the future, please don't hesitate to enter jira issues, even if you unable to provide patch.

 Thanks

 Eugene


MATHUS Baptiste wrote:

Hi all,

We happen to have a project whose name is something like "Project Name" (i.e. containing a space) and its version is say "2.1". M2E version decorator will decorate the version between "Project" and "Name", giving something like "Project 2.1 Name".

Here's the relevant code:
         ...
         if(mavenProject!=null) {
            int n = text.indexOf(' ');
            if(n==-1) {
              return text + "  " + mavenProject.getVersion();
            }
return text.substring(0, n) + " " + mavenProject.getVersion() + text.substring(n);
          }

It looks like this was made on purpose (I mean not just putting the version at the end of the string). Is this the case? We don't find it very easy to read like this, but there might be a rationale behind this behaviour we're not aware of. Obviously, if not, I'll be happy to propose a patch and the corresponding test.

Please let me know what you think.
Thanks.



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to