Sorry about the piecemeal observations. I'm currently in Beijing and don't have a lot of extra large time chunks to review the release in one sitting.
1) There are still three outstanding Jira issues in an "Unresolved" state with a fix version of v1.11. Are they going to be resolved soon? They can be seen with the following url: https://issues.apache.org/jira/browse/MADLIB/fixforversion/12339592/?selectedTab=com.atlassian.jira.jira-projects-plugin:version-summary-panel 2) As it relates to the convenience binary release, I noticed an inconsistent MADLIB_GIT_REVISION value (rel/v1.10.0) spread throughout several SQLCommon.m4 files. Shouldn't the reference be to v1.11 instead of v1.10? -------------------------------------------- MAC (notice rel/v1.10.0-30-g0ff829a value): -------------------------------------------- ✔ /usr/local/madlib/Versions 23:42 $ grep -n -i -r MADLIB_GIT_REVISION * 1.11/ports/greenplum/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' 1.11/ports/hawq/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' 1.11/ports/postgres/9.4/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-30-g0ff829a') 1.11/ports/postgres/9.5/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-30-g0ff829a') 1.11/ports/postgres/9.6/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-30-g0ff829a') 1.11/ports/postgres/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' -------------------------------------------- Linux (notice rel/v1.10.0-31-gd54be2b value): -------------------------------------------- [root@ip-172-31-9-242 Versions]# rpm -qa | grep madlib madlib-1.11-1.x86_64 [root@ip-172-31-9-242 Versions]# pwd /usr/local/madlib/Versions [root@ip-172-31-9-242 Versions]# grep -n -i -r MADLIB_GIT_REVISION * 1.11/ports/greenplum/4.2/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/greenplum/4.3/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/greenplum/4.3ORCA/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/greenplum/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' 1.11/ports/hawq/2/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/hawq/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' 1.11/ports/postgres/9.5/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/postgres/9.6/madpack/SQLCommon.m4:20:m4_define(`__MADLIB_GIT_REVISION__', `rel/v1.10.0-31-gd54be2b') 1.11/ports/postgres/modules/utilities/utilities.sql_in:122: 'git revision: __MADLIB_GIT_REVISION__, ' [root@ip-172-31-9-242 Versions]# On Wed, May 3, 2017 at 12:15 PM, Ed Espino <esp...@apache.org> wrote: > I have taken a quick look at the DMG and a Linux RPM binary artifacts > (sorry haven't had time to build and/or test the binaries yet). But this > info might be of some benefit to the team sooner than later. > > Regards, > -=e > -- > *Ed Espino* > > ====================================================================== > PGP signature (source and convenience binaries): good > ====================================================================== > Hashes (source and convenience binaries): good > ====================================================================== > Source directory layout: good > ====================================================================== > Source LICENSE, DISCLAIMER & NOTICE: good > ====================================================================== > Apache Release Audit Tool (RAT): > > Observation: > > - I happened to open the file "CMakeLists.txt" in the root directory > and noticed it does not have the standard ASF header. I know there > were IP issues resolved globally for the project recently. I > noticed many of them are excluded in the pom.xml file. Regardless > of the IP issues, shouldn't these files contain the ASF header? > > ====================================================================== > Source miscelaneous: HAWQ_Install.txt > > Observation: > > - The file references the product name as "MADlib" and not "Apache > MADlib (Incubating). Is this file still valid? > > ====================================================================== > CONVENIENCE BINARIES > ---------------------------------------------------------------------- > > ---------------------------------------------------------------------- > Mac Installer DMG file: apache-madlib-1.11-incubating-bin-Darwin.dmg > ---------------------------------------------------------------------- > > Observation: > > - The DMG（apache-madlib-1.11-incubating-bin-Darwin.dmg) contains a > pkg file named "madlib-1.11-Darwin.pkg". Shouldn't it be called > "apache-madlib-1.11-incubating-Darwin.pkg"? > > Similarly, the DMG base folder name is madlib-1.11.Darwin. > > Mac Installer Package > > o Introduction screen > > Observation: > > - The introduction screen identifies the product name as > "MADlib". Shouldn't there be a mention of the project name being > "Apache MADlib (Incubating)". > > o Read Me screen > > Observation: > > - Similar to initial screen, there is no mention to the Apache > project except for the link to the project's wiki. > > o Remaining screens look reasonable (with exception of no Apache > references). > > o The default application window name is "Install MADlib" > > Observation: > > - Similar to Introduction sreen, should the name be "Install Apache > MADlib (Incubating)"? > > - Look for other opportunities to reference the product name as > "Apache MADlib (Incubating)". > > ---------------------------------------------------------------------- > Linux RPM: apache-madlib-1.11-incubating-bin-Linux.rpm > ---------------------------------------------------------------------- > > Observation: > > - It appears the SPEC file used (possibly generated) references the > product name as "madlib". Again, shouldn't there be references to > the product name as "Apache MADlib" scattered about? > Unfortunately, I am not sure if this should change or not. It > might help for someone on the team to review other Apache projects > convenience binary RPMs to see if something should be > addressed. The podling's mentor might be able to provide > additional direction as well. > > This can be seen in the following "rpm -qi madlib" output: > > [root@e0f4d3349d2d MADlib]# rpm -qi madlib > Name : madlib > Version : 1.11 > Release : 1 > Architecture: x86_64 > Install Date: Wed May 3 04:00:10 2017 > Group : Development/Libraries > Size : 83575356 > License : ASL 2.0 > Signature : (none) > Source RPM : madlib-1.11-1.src.rpm > Build Date : Tue May 2 19:03:21 2017 > Build Host : gpdb1.eng.pivotal.io > Relocations : /usr/local > Vendor : MADlib > Summary : Open-Source Library for Scalable in-Database > Analytics > Description : > MADlib is an open-source library for scalable in-database > analytics. It > provides data-parallel implementations of mathematical, > statistical and > machine learning methods for structured and unstructured data. > > The MADlib mission: to foster widespread development of scalable > analytic skills, by harnessing efforts from commercial practice, > academic research, and open-source development. > > To more information, please see the MADlib wiki at > https://cwiki.apache.org/confluence/display/MADLIB > > ---------------------------------------------------------------------- > > On Wed, May 3, 2017 at 8:13 AM, Frank McQuillan <fmcquil...@pivotal.io> > wrote: > >> Thanks for updating to RC-2, Rashmi. >> >> I just tried the dmg on OSX on PG9.6 on my local machine and the soft link >> seems to be set correctly now, since it upgraded 1.11 over 1.10 OK. When >> I >> uninstalled MADlib and did a fresh install, that worked fine too for 1.11. >> So... >> >> +1 >> >> Frank >> >> On Tue, May 2, 2017 at 5:01 PM, Rashmi Raghu <rra...@pivotal.io> wrote: >> >> > Hello MADlib community, >> > >> > We have created a MADlib 1.11 RC-2, with the artifacts below (source and >> > convenience binaries) up for a vote. >> > >> > Note that voting for the RC-1 release has been cancelled due to the need >> > for minor corrections based on community feedback. Sorry for the >> > inconvenience. >> > >> > RC-2 replaces RC-1 with the following minor changes: >> > * Ensure source tarball unpacks into a folder >> > * Ensure soft links are correct for OS X installations >> > >> > This will be the 5th release for Apache MADlib (incubating). >> > >> > The main goals of this release are: >> > * new module (PageRank for graph analytics with grouping support >> included) >> > * improvements to existing modules (add grouping support to Single >> Source >> > Shortest Path, reduce memory footprint of DT and RF, include NULL >> features >> > in training DT, add support for array and svec output for Pivot module, >> > utility to unnest 2-D arrays into rows of 1-D arrays) >> > * platform updates (GPDB 5) >> > * updates for Apache Top Level Project readiness and build process on >> > Apache infrastructure >> > * bug fixes >> > * doc improvements >> > >> > For more information including release notes, please see: >> > https://cwiki.apache.org/confluence/display/MADLIB/MADlib+1.11 >> > >> > *** Please download, review and vote by Fri May 05, 2017 @ 6pm PDT *** >> > >> > We're voting upon the source and convenience binaries below: >> > >> > Source Repository (tag): rc/1.11-rc2 >> > https://github.com/apache/incubator-madlib/tree/rc/1.11-rc2 >> > >> > Source Files and convenience Binaries: >> > https://dist.apache.org/repos/dist/dev/incubator/madlib/1. >> > 11-incubating-rc2/ >> > >> > Commit: >> > https://github.com/apache/incubator-madlib/commit/ >> > d54be2b8574c5bf0ace96b94ba81f3e5cbf70a35 >> > >> > KEYS file containing PGP Keys we use to sign the release: >> > https://dist.apache.org/repos/dist/dev/incubator/madlib/KEYS >> > >> > To help in tallying the vote, PMC members please be sure to indicate >> > "(binding)" with the vote. >> > >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove (and reason why) >> > >> > >> > Regards, >> > Rashmi Raghu >> > >> > -- >> > Rashmi Raghu, Ph.D. >> > Pivotal Data Science >> > >> > > > -- *Ed Espino*
