On Tue, Jul 6, 2010 at 1:17 PM, Grant Ingersoll <[email protected]> wrote: > > Hmm, I was looking at the code and it is passed into DistributedMatrix, > etc., so it seemed like it was needed. >
Yep, that's why I made sure it was required. It just turns out that nothing in the Lanczos code ever uses the numRows value of said DistributedRowMatrix - it only computes "timesSquared(Vector)", which uses the column space. Unless you're doing a symmetric matrix, in which case it does times(Vector). But if you've got a symmetric matrix, and you know the dim of the columns, you also know numRows. :) > > Glad to see some more other committers playing with the SVD code finally > - I > > should have pretended I left those hacks in on purpose specifically to > see > > when y'all would use it and mention how horrible it was. :P > > > > You're hacks beat my non-existent SVD code! > Heh, sure sure. Still, I really do need to clean up these hacks one of these days... -jake
