Please attach the patch as a diff file to the ticket. [3] I can calculate a diff from the pull request but having it as an actual diff attachment is far easier.
Thanks, Karl On Tue, Aug 2, 2016 at 1:51 PM, Furkan KAMACI <[email protected]> wrote: > Hi, > > I've create my first issue related to LDAP Connector [1]. I've created a > PR for it at Github [2]. However it didn't synchronize at Jira as comment. > Should I use svn to contribute as described here: [2] or attach the patch > as file via Submit Patch button at Jira issue? > > [1] https://issues.apache.org/jira/browse/CONNECTORS-1329 > [2] https://github.com/apache/manifoldcf/pull/9 > [3] https://cwiki.apache.org/confluence/display/CONNECTORS/HowToContribute > > Kind Regards, > Furkan KAMACI > > On Tue, Aug 2, 2016 at 11:23 AM, Furkan KAMACI <[email protected]> > wrote: > >> Hi Karl, >> >> OK, I see that bug is fixed at trunk and not in 2.4. >> >> Kind Regards, >> Furkan KAMACI >> >> On Tue, Aug 2, 2016 at 11:15 AM, Furkan KAMACI <[email protected]> >> wrote: >> >>> Hi Karl, >>> >>> I couldn't see release-2.4 tag. There is a release 2.4 branch and it has >>> same bug: >>> https://github.com/apache/manifoldcf/blob/release-2.4-branch/connectors/ldap/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/ldap/LDAPAuthority.java >>> Could >>> you point me the Github adress of related tag? >>> >>> By the way I'll use trunk for my patches. >>> >>> Kind Regards, >>> Furkan KAMACI >>> >>> On Mon, Aug 1, 2016 at 9:45 PM, Karl Wright <[email protected]> wrote: >>> >>>> Hi Furkan, >>>> >>>> (1) The tag you want is: release-2.4 >>>> (2) If you are preparing patches, please prepare them against trunk. >>>> >>>> Thanks! >>>> Karl >>>> >>>> >>>> >>>> On Mon, Aug 1, 2016 at 2:15 PM, Furkan KAMACI <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> I could find the reason. It's due to the bug that has been resolved at >>>>> 20 April 2016: >>>>> https://github.com/apache/manifoldcf/commit/3565278b71ad32cb6b8789955ba5491cee07d0e0 >>>>> When >>>>> I check ManifoldCF website I see that last release is 2.4: >>>>> https://manifoldcf.apache.org/en_US/index.html#23+Apr+2016+-+ManifoldCF+2.4+is+released%21 >>>>> So, >>>>> I used release-2.4-RC0 tag at Github. However, last commit >>>>> to LDAPAuthority.java is from last year: >>>>> https://github.com/apache/manifoldcf/commit/68164f7a5e19b0cc486e2a4d99af67d83ef4f0f0 >>>>> >>>>> I have 2 questions. >>>>> >>>>> 1) Which one is the 2.4 tag at Github? >>>>> 2) I've created a patch to fix problems at LDAPAuthority.java. For >>>>> which branch I should prepare it, trunk? >>>>> >>>>> Kind Regards, >>>>> Furkan KAMACI >>>>> >>>>> On Fri, Jul 29, 2016 at 10:00 PM, Furkan KAMACI < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> When I use either Jxplorer or Apache Open Directory I use that info: >>>>>> >>>>>> Hostname: localhost >>>>>> Port: 389 >>>>>> Encryption Method: No Encryption >>>>>> Authentication Parameters: >>>>>> Bind DN or user: cn=admin,dc=hostname,dc=example,dc=com >>>>>> Password: ******* >>>>>> >>>>>> I can successfully connect to OpenLDAP (openldap-2.4.31). However >>>>>> when I try to configure Authority Connection at ManifoldCF (2.4) I >>>>>> cannot. >>>>>> These are my Authority Connection definition: >>>>>> >>>>>> LDAP server name: localhost >>>>>> LDAP server port: 389 >>>>>> LDAP server base (e.g. 'dc=office,dc=com'): >>>>>> dc=hostname,dc=example,dc=com >>>>>> Bind to server as user (leave empty if not needed): admin >>>>>> Bind to server with password: ******* >>>>>> User search base: ou=People >>>>>> User search filter: (&(objectClass=inetOrgPerson)(uid={0})) >>>>>> Add user as authorization token: No >>>>>> User name attribute: uid >>>>>> Group search base: ou=Groups >>>>>> Group search filter: (&(objectClass=groupOfNames)(member={0})) >>>>>> Group name attribute: cn >>>>>> Member attribute is DN: Yes >>>>>> >>>>>> It says: "Threw exception: 'Communication error: localhost:389'" as >>>>>> connection status. When I check log file there is nothing at there: >>>>>> dist/example/logs/manifoldcf.log >>>>>> >>>>>> Any ideas? >>>>>> >>>>>> There >>>>>> Kind Regards, >>>>>> Furkan KAMACI >>>>>> >>>>> >>>>> >>>> >>> >> >
