There were a number of files committed.
On Tue, Aug 14, 2018 at 9:02 AM Bisonti Mario <mario.biso...@vimar.com> wrote: > I don’t obtain a different result.. > > Where could I check the commit? > > Which is the file commited , so I can check it ? > > Thanks a lot > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* martedì 14 agosto 2018 14:17 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Ok, I committed code that insures that all times displayed in reports are > in the browser client timezone. The same timezone is used throughout. > Hopefully this will clear up any remaining confusion. > > > > Karl > > > > > > On Tue, Aug 14, 2018 at 6:33 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > This from http://browserspy.dk/date.php > <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbrowserspy.dk%2Fdate.php&data=01%7C01%7CMario.Bisonti%40vimar.com%7C84606c76fe814a5198d208d601dfdb32%7Ca1f008bcd59b4c668f8760fd9af15c7f%7C1&sdata=qlFuFMjwu%2BXeM%2BGqmtLtRmPMw5QFVhd%2BqpMix7agMZQ%3D&reserved=0> > > > > > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* martedì 14 agosto 2018 12:20 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Hi Mario, > > > > I did not change how the Start Time filter was defined in the UI at all. > The only change was in how the report data was presented. > > > > Can you please check your browser time? > > > > Karl > > > > > > On Tue, Aug 14, 2018 at 6:13 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Hi Karl. > > > > In my environment, browser time and server timezone are the same. > > > > Before the modification, I saw that the “Start Time:” filter was right, so > in the timezone of the browser, equal to the server timezone (Europe/Rome) > > Instead the report, had the column “start Time” equal to my timezone plus > two hours. > > > > After the modification, I see that the “Start Time:” filter timezone less > one hour, Instead the report, has the column “start Time” equal to my > timezone less two hours. > > > > After,for mw, the server timezone, equal to the browser timezone, would be > right if they would be equal to the “Start time:” filter and to the “Start > time column” > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* martedì 14 agosto 2018 12:04 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Hi Mario, > > > > The UI uses browser time exclusively. The columns displayed, however, are > based on the server's time. This is how MCF functioned up until the year > 2016, when the columns were changed to display UTC instead. I reverted > that behavior with my commit. > > > > I am not sure I know what it is you are asking for me to do here. Do you > want all times displayed in UTC? Or, all times displayed in the browser > timezone? Or all times displayed in the server timezone? > > > > Karl > > > > > > On Tue, Aug 14, 2018 at 5:13 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Hallo. > > I compiled, but with this version I see the time 2 hour less of the right > time and the report seems wrong time by the actual time as you can see in > the attachment. > > > > So I rollback to the previous version. > > > > > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* venerdì 10 agosto 2018 17:23 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Try it now. > > > > Karl > > > > > > On Fri, Aug 10, 2018 at 10:57 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Yes > > sudo ant make-core-deps > > Buildfile: /home/administrator/mcfsorce/trunk/build.xml > > Trying to override old definition of task javac > > > > BUILD FAILED > > /home/administrator/mcfsorce/trunk/build.xml:2929: taskdef class > de.thetaphi.forbiddenapis.ant.AntTask cannot be found > > using the classloader AntClassLoader[] > > > > Total time: 0 seconds > > administrator@sengvivv01:~/mcfsorce/trunk$ > > > > But the downloaded trunk directory is very small, instead the last trunk > was bigger: > > administrator@sengvivv01:~/mcfsorce$ du -sh tr* > > 121M trunk > > 1.8G trunk_19062018 > > > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* venerdì 10 agosto 2018 16:47 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Did you first do: > > > > ant make-core-deps > > > > ? > > Karl > > > > > > On Fri, Aug 10, 2018 at 5:04 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Thanks Karl. > > I tried to compile the trunk version but I obtian: > > Buildfile: /home/administrator/mcfsorce/trunk/build.xml > > Trying to override old definition of task javac > > > > BUILD FAILED > > /home/administrator/mcfsorce/trunk/build.xml:2929: taskdef class > de.thetaphi.forbiddenapis.ant.AntTask cannot be found > > using the classloader AntClassLoader[] > > > > > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* venerdì 10 agosto 2018 10:53 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > I've committed a change to trunk which will restore the pre-2016 behavior. > > > > Karl > > > > On Fri, Aug 10, 2018 at 3:40 AM Karl Wright <daddy...@gmail.com> wrote: > > The code that formats the time is here: > > > > >>>>>> > > String startTimeString = > org.apache.manifoldcf.ui.util.Formatter.formatTime(Converter.asLong(row.getValue("starttime"))); > > <<<<<< > > > > This explicitly uses UTC as the timezone: > > >>>>>> > > /** Format a long as an understandable date. > > *@param time is the long. > > *@return the date, as a human-readable string. This date will be in > local time. > > */ > > public static String formatTime(long time) > > { > > Calendar c = new GregorianCalendar(TimeZone.getTimeZone("UTC"), > Locale.ROOT); > > c.setTimeInMillis(time); > > // We want to format this string in a compact way: > > // mm-dd-yyyy hh:mm:ss.mmm > > StringBuilder returnString = new StringBuilder(); > > writechars(returnString,c.get(Calendar.MONTH)+1,2); > > returnString.append("-"); > > writechars(returnString,c.get(Calendar.DAY_OF_MONTH),2); > > returnString.append("-"); > > writechars(returnString,c.get(Calendar.YEAR),4); > > returnString.append(" "); > > writechars(returnString,c.get(Calendar.HOUR_OF_DAY),2); > > returnString.append(":"); > > writechars(returnString,c.get(Calendar.MINUTE),2); > > returnString.append(":"); > > writechars(returnString,c.get(Calendar.SECOND),2); > > returnString.append("."); > > writechars(returnString,c.get(Calendar.MILLISECOND),3); > > return returnString.toString(); > > } > > <<<<<< > > This was last changed: > > >>>>>> > > 1756230 kwright Calendar c = new > GregorianCalendar(TimeZone.getTimeZone("UTC"), Locale.ROOT); > > <<<<<< > > > > The reason for the change: > > >>>>>> > > ------------------------------------------------------------------------ > > r1756230 | kwright | 2016-08-12 18:20:00 -0400 (Fri, 12 Aug 2016) | 1 line > > > > Fix for CONNECTORS-1332. Committed on behalf of Furkan KAMACI. > > <<<<<< > > CONNECTORS-1332 is about calling forbidden APIS: > > > > >>>>>> > > We should avoid forbidden calls > <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpoliceman-tools%2Fforbidden-apis%2Fwiki&data=01%7C01%7CMario.Bisonti%40vimar.com%7C84606c76fe814a5198d208d601dfdb32%7Ca1f008bcd59b4c668f8760fd9af15c7f%7C1&sdata=7%2B29uLy9Hu%2FdZE60kzfyUD0iNY0nbtisV7TQQGgTZYk%3D&reserved=0> > and > check for it in the ant build. > > <<<<<< > > > > The actual change was: > > >>>>>> > > C:\wip\mcf\trunk\framework\ui-core\src\main\java\org\apache\manifoldcf\ui\util>svn > diff -c 1756230 > > Index: Formatter.java > > =================================================================== > > --- Formatter.java (revision 1756229) > > +++ Formatter.java (revision 1756230) > > @@ -32,7 +32,7 @@ > > */ > > public static String formatTime(long time) > > { > > - Calendar c = new GregorianCalendar(); > > + Calendar c = new GregorianCalendar(TimeZone.getTimeZone("UTC"), > Locale.ROOT); > > c.setTimeInMillis(time); > > // We want to format this string in a compact way: > > // mm-dd-yyyy hh:mm:ss.mmm > > <<<<<< > > > > > > As you see, formerly the timezone was local time. The change required an > explicit timezone in order to pass the forbidden APIs test, and UTC was > used. > > I am happy to try to change this since it's been this way only since 2016, > if I can find a way that will not break forbiddenAPIs. > > > > Karl > > > > > > On Fri, Aug 10, 2018 at 2:42 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Hallo Karl. > > My server timezone is set as the browser timezone (europe/Rome) as you can > see, but the list is two hour less my time zone. > > So, it seems that the list uses the “universal time” instead of time zone > > > > administrator@sengvivv01:~$ timedatectl > > Local time: Fri 2018-08-10 08:39:28 CEST > > Universal time: Fri 2018-08-10 06:39:28 UTC > > RTC time: Fri 2018-08-10 06:39:28 > > Time zone: Europe/Rome (CEST, +0200) > > System clock synchronized: yes > > systemd-timesyncd.service active: yes > > RTC in local TZ: no > > > > > > What could I do? > > Thanks a lot > > > > > > > > *Da:* Karl Wright <daddy...@gmail.com> > *Inviato:* giovedì 9 agosto 2018 21:36 > *A:* user@manifoldcf.apache.org > *Oggetto:* Re: Different time in Simple History Report > > > > Hi Mario. > > The pulldown allows you to select times based on the current (browser) > time zone. > > The display is in *server* timezone. That accounts for the difference. > > > > Karl > > > > > > On Thu, Aug 9, 2018 at 10:23 AM Bisonti Mario <mario.biso...@vimar.com> > wrote: > > Hallo > > I see a difference from the start time in “Simple History Report” > > > > It seems late of 2 hours. > > > > Have I to set timezone for this report? > > > > Thanks a lot > > See the attachment > > > > > >
diff
Description: Binary data