To be clear, I'm a binding -1 without this fix pulled in unless folks can convince me otherwise. :)
Are we sure that folks are even using the consecutive failure health check feature successfully? When a colleague showed me how he ran into this bug, it was happening with a pretty high frequency! This led to us spending hours figuring out what was wrong. That's a really bad experience to give users, and might be the kind of thing that bites us and warrants a 0.26.1. Happy to vote promptly on the next RC! Thanks for all the hard work so far with the release, it really is appreciated. On Thu, Dec 10, 2015 at 11:22 AM, Benjamin Mahler <[email protected] > wrote: > What is the workaround? > > On Thu, Dec 10, 2015 at 4:37 AM, Bernd Mathiske <[email protected]> > wrote: > >> I think that whereas this would clearly be a desirable bug fix to have, >> it is not a blocker: >> - Not a regression. This problem has been around for a long time, since >> 0.20 AFAIK. >> - There is a simple workaround. >> >> Bernd >> >> On Dec 10, 2015, at 3:05 AM, Benjamin Mahler <[email protected]> >> wrote: >> >> I'd really like to pull in the fix for: >> https://issues.apache.org/jira/browse/MESOS-4106 >> >> This has been a long standing bug that makes the health checking not >> function correctly some of the time. While it is rare in CI, it appeared in >> a colleague's cluster for about a third of the tasks he was launching to >> demonstrate how he ran into this. The fix is trivial and is in review. >> >> Thoughts? >> >> On Tue, Dec 8, 2015 at 7:01 AM, Bernd Mathiske <[email protected]> >> wrote: >> >>> +1 (binding) >>> >>> Ran make check, make distcheck, sudo bin/mesos-tests.sh, with SSL >>> enabled and without on: Ubuntu 12.04, CentOS 7.1. >>> >>> Had 4 test failures with CentOS 7.1 for each configuration variant. All >>> of the failed tests are known to be flaky, they have MESOS tickets, and >>> they have been investigated and are deemed non-blockers. >>> >>> Bernd >>> >>> > On Dec 8, 2015, at 4:59 AM, Till Toenshoff <[email protected]> wrote: >>> > >>> > Hi friends, >>> > >>> > we had noticed some discrepancies between the V0 API and the V1 API, >>> > hence we had to create a new release candidate even after the voting of >>> > 0.26.0-rc3 had officially ended. Sorry for that! >>> > >>> > Please vote on releasing the following candidate as Apache Mesos >>> 0.26.0. >>> > >>> > The CHANGELOG for the release is available at: >>> > >>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.26.0-rc4 >>> > >>> -------------------------------------------------------------------------------- >>> > >>> > The candidate for Mesos 0.26.0 release is available at: >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/0.26.0-rc4/mesos-0.26.0.tar.gz >>> > >>> > The tag to be voted on is 0.26.0-rc4: >>> > >>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.26.0-rc4 >>> > >>> > The MD5 checksum of the tarball can be found at: >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/0.26.0-rc4/mesos-0.26.0.tar.gz.md5 >>> > >>> > The signature of the tarball can be found at: >>> > >>> https://dist.apache.org/repos/dist/dev/mesos/0.26.0-rc4/mesos-0.26.0.tar.gz.asc >>> > >>> > The PGP key used to sign the release is here: >>> > https://dist.apache.org/repos/dist/release/mesos/KEYS >>> > >>> > The JAR is up in Maven in a staging repository here: >>> > https://repository.apache.org/content/repositories/orgapachemesos-1093 >>> > >>> > Please vote on releasing this package as Apache Mesos 0.26.0! >>> > >>> > The vote is open until Fri Dec 11 04:50:51 CET 2015 and passes if a >>> majority of at least 3 +1 PMC votes are cast. >>> > >>> > [ ] +1 Release this package as Apache Mesos 0.26.0 >>> > [ ] -1 Do not release this package because ... >>> > >>> > Thanks, >>> > Bernd & Till >>> > >>> >>> >> >> >
