Tim, What about https://reviews.apache.org/r/42516/ for user-defined network in docker containerizer, the user defined network has been landed in docker for quite a while and it is better to enable mesos docker containerizer support this.
Thanks, Guangya On Thu, Mar 10, 2016 at 2:00 AM, Kevin Klues <klue...@gmail.com> wrote: > Tim, > > Is there a review other than the following for MESOS-4370? > > Restore Mesos' ability to extract Docker assigned IPs (still under review): > https://reviews.apache.org/r/43093/ > > If not, it was already on the list, but has not yet landed. > > On Wed, Mar 9, 2016 at 9:57 AM, Timothy Chen <tnac...@gmail.com> wrote: > > Also like to include MESOS-4370 as it fixes IP Address look up logic > > and also unblocks users using custom Docker network. > > > > Tim > > > > On Wed, Mar 9, 2016 at 9:55 AM, Gilbert Song <gilb...@mesosphere.io> > wrote: > >> Hi Kevin, > >> > >> Please remove the the patch below from the list: > >> Implemented runtime isolator default cmd test (still under review). > >> https://reviews.apache.org/r/44469/ > >> > >> Because the bug was fixed by patch #44468, the test should not be > >> considered as a block. I am updating MESOS-4888 and move the test to a > >> separate JIRA. > >> > >> Thanks, > >> Gilbert > >> > >> On Tue, Mar 8, 2016 at 2:43 PM, Kevin Klues <klue...@gmail.com> wrote: > >> > >>> Here are the list of reviews/patches that have been called out in this > >>> thread for inclusion in 0.28.0-rc2. Some of them are still under > >>> review and will need to land by Thursday to be included. > >>> > >>> Are there others? > >>> > >>> Jie's container image documentation (submitted): > >>> commit 7de8cdd4d8ed1d222fa03ea0d8fa6740c4a9f84b > >>> https://reviews.apache.org/r/44414 > >>> > >>> Restore Mesos' ability to extract Docker assigned IPs (still under > review): > >>> https://reviews.apache.org/r/43093/ > >>> > >>> Fixed the logic for default docker cmd case (submitted). > >>> commit e42f740ccb655c0478a3002c0b6fa90c1144f41c > >>> https://reviews.apache.org/r/44468/ > >>> > >>> Implemented runtime isolator default cmd test (still under review). > >>> https://reviews.apache.org/r/44469/ > >>> > >>> Fixed a bug that causes the task stuck in staging state (still under > >>> review). > >>> https://reviews.apache.org/r/44435/ > >>> > >>> On Tue, Mar 8, 2016 at 10:30 AM, Kevin Klues <klue...@gmail.com> > wrote: > >>> > Yes, will do. > >>> > > >>> > On Tue, Mar 8, 2016 at 10:26 AM, Vinod Kone <vinodk...@apache.org> > >>> wrote: > >>> >> +kevin klues > >>> >> > >>> >> OK. I'm cancelling this vote since there are some show stopper > issues > >>> that > >>> >> we need to cherry-pick. I'll cut another RC on Thursday. > >>> >> > >>> >> @shepherds: can you please make sure the blocker tickets are marked > with > >>> >> fix version and that they land today or tomorrow? > >>> >> > >>> >> @kevin: since you have volunteered to help with the release, can you > >>> make > >>> >> sure we have a list of commits to cherry pick for rc2? > >>> >> > >>> >> Thanks, > >>> >> > >>> >> > >>> >> On Tue, Mar 8, 2016 at 12:05 AM, Shuai Lin <linshuai2...@gmail.com> > >>> wrote: > >>> >> > >>> >>> Maybe also https://issues.apache.org/jira/browse/MESOS-4877 and > >>> >>> https://issues.apache.org/jira/browse/MESOS-4878 ? > >>> >>> > >>> >>> > >>> >>> On Tue, Mar 8, 2016 at 9:13 AM, Jie Yu <yujie....@gmail.com> > wrote: > >>> >>> > >>> >>>> I'd like to fix https://issues.apache.org/jira/browse/MESOS-4888 > as > >>> well > >>> >>>> if you guys plan to cut another RC > >>> >>>> > >>> >>>> On Mon, Mar 7, 2016 at 10:16 AM, Daniel Osborne < > >>> >>>> daniel.osbo...@metaswitch.com> wrote: > >>> >>>> > >>> >>>>> -1 > >>> >>>>> > >>> >>>>> If it doesn’t cause too much pain, I'm hoping we can squeeze a > >>> >>>>> relatively small patch which restores Mesos' ability to extract > >>> Docker > >>> >>>>> assigned IPs. This has been broken with Docker 1.10's release > over > >>> a month > >>> >>>>> ago, and prevents service discovery and DNS from working. > >>> >>>>> > >>> >>>>> Mesos-4370: https://issues.apache.org/jira/browse/MESOS-4370 > >>> >>>>> RB# 43093: https://reviews.apache.org/r/43093/ > >>> >>>>> > >>> >>>>> I've built 0.28.0-rc1 with this patch and can confirm that it > fixes > >>> it > >>> >>>>> as expected. > >>> >>>>> > >>> >>>>> Apologies for not bringing this to attention earlier. > >>> >>>>> > >>> >>>>> Thanks all, > >>> >>>>> Dan > >>> >>>>> > >>> >>>>> -----Original Message----- > >>> >>>>> From: Vinod Kone [mailto:vinodk...@apache.org] > >>> >>>>> Sent: Thursday, March 3, 2016 5:44 PM > >>> >>>>> To: dev <d...@mesos.apache.org>; user <user@mesos.apache.org> > >>> >>>>> Subject: [VOTE] Release Apache Mesos 0.28.0 (rc1) > >>> >>>>> > >>> >>>>> Hi all, > >>> >>>>> > >>> >>>>> > >>> >>>>> Please vote on releasing the following candidate as Apache Mesos > >>> 0.28.0. > >>> >>>>> > >>> >>>>> > >>> >>>>> 0.28.0 includes the following: > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > -------------------------------------------------------------------------------- > >>> >>>>> > >>> >>>>> * [MESOS-4343] - A new cgroups isolator for enabling the > net_cls > >>> >>>>> subsystem in > >>> >>>>> > >>> >>>>> Linux. The cgroups/net_cls isolator allows operators to > provide > >>> >>>>> network > >>> >>>>> > >>> >>>>> > >>> >>>>> performance isolation and network segmentation for containers > >>> within > >>> >>>>> a Mesos > >>> >>>>> > >>> >>>>> cluster. To enable the cgroups/net_cls isolator, append > >>> >>>>> `cgroups/net_cls` to > >>> >>>>> > >>> >>>>> the `--isolation` flag when starting the slave. Please refer > to > >>> >>>>> > >>> >>>>> > >>> >>>>> docs/mesos-containerizer.md for more details. > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-4687] - The implementation of scalar resource values > >>> (e.g., > >>> >>>>> "2.5 > >>> >>>>> > >>> >>>>> > >>> >>>>> CPUs") has changed. Mesos now reliably supports resources > with > >>> up to > >>> >>>>> three > >>> >>>>> > >>> >>>>> decimal digits of precision (e.g., "2.501 CPUs"); resources > with > >>> >>>>> more than > >>> >>>>> > >>> >>>>> three decimal digits of precision will be rounded. > Internally, > >>> >>>>> resource math > >>> >>>>> > >>> >>>>> is now done using a fixed-point format that supports three > >>> decimal > >>> >>>>> digits of > >>> >>>>> > >>> >>>>> precision, and then converted to/from floating point for > input > >>> and > >>> >>>>> output, > >>> >>>>> > >>> >>>>> respectively. Frameworks that do their own resource math and > >>> >>>>> manipulate > >>> >>>>> > >>> >>>>> > >>> >>>>> fractional resources may observe differences in roundoff > error > >>> and > >>> >>>>> numerical > >>> >>>>> > >>> >>>>> precision. > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-4479] - Reserved resources can now optionally include > >>> >>>>> "labels". > >>> >>>>> > >>> >>>>> > >>> >>>>> Labels are a set of key-value pairs that can be used to > associate > >>> >>>>> metadata > >>> >>>>> > >>> >>>>> with a reserved resource. For example, frameworks can use > this > >>> >>>>> feature to > >>> >>>>> > >>> >>>>> distinguish between two reservations for the same role at the > >>> same > >>> >>>>> agent > >>> >>>>> > >>> >>>>> that are intended for different purposes. > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-2840] - **Experimental** support for container images > in > >>> Mesos > >>> >>>>> > >>> >>>>> > >>> >>>>> containerizer (a.k.a. Unified Containerizer). This allows > >>> frameworks > >>> >>>>> to > >>> >>>>> > >>> >>>>> > >>> >>>>> launch Docker/Appc containers using Mesos containerizer > without > >>> >>>>> relying on > >>> >>>>> > >>> >>>>> docker daemon (engine) or rkt. The isolation of the > containers is > >>> >>>>> done using > >>> >>>>> > >>> >>>>> isolators. Please refer to docs/container-image.md for > currently > >>> >>>>> supported > >>> >>>>> > >>> >>>>> features and limitations. > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-4793] - **Experimental** support for v1 Executor HTTP > API. > >>> >>>>> This > >>> >>>>> > >>> >>>>> > >>> >>>>> allows executors to send HTTP requests to the > /api/v1/executor > >>> agent > >>> >>>>> > >>> >>>>> > >>> >>>>> endpoint without the need for an executor driver. Please > refer to > >>> >>>>> > >>> >>>>> > >>> >>>>> docs/executor-http-api.md for more details. > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> >>>>> Additional API Changes: > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-4066] - Agent should not return partial state when a > >>> request > >>> >>>>> is made to /state endpoint during recovery. > >>> >>>>> > >>> >>>>> * [MESOS-4547] - Introduce TASK_KILLING state. > >>> >>>>> > >>> >>>>> > >>> >>>>> * [MESOS-4712] - Remove 'force' field from the Subscribe Call > in v1 > >>> >>>>> Scheduler API. > >>> >>>>> > >>> >>>>> * [MESOS-4591] - Change the object of ReserveResources and > >>> >>>>> CreateVolume ACLs to `roles`. > >>> >>>>> > >>> >>>>> * [MESOS-4712] - Remove 'force' field from the Subscribe Call > in v1 > >>> >>>>> Scheduler API. > >>> >>>>> > >>> >>>>> * [MESOS-4591] - Change the object of ReserveResources and > >>> >>>>> CreateVolume ACLs to `roles`. > >>> >>>>> > >>> >>>>> * [MESOS-3583] - Add stream IDs for HTTP schedulers. > >>> >>>>> > >>> >>>>> > >>> >>>>> The CHANGELOG for the release is available at: > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.28.0-rc1 > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > -------------------------------------------------------------------------------- > >>> >>>>> > >>> >>>>> > >>> >>>>> The candidate for Mesos 0.28.0 release is available at: > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > https://dist.apache.org/repos/dist/dev/mesos/0.28.0-rc1/mesos-0.28.0.tar.gz > >>> >>>>> > >>> >>>>> > >>> >>>>> The tag to be voted on is 0.28.0-rc1: > >>> >>>>> > >>> >>>>> > >>> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.28.0-rc1 > >>> >>>>> > >>> >>>>> > >>> >>>>> The MD5 checksum of the tarball can be found at: > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > https://dist.apache.org/repos/dist/dev/mesos/0.28.0-rc1/mesos-0.28.0.tar.gz.md5 > >>> >>>>> > >>> >>>>> > >>> >>>>> The signature of the tarball can be found at: > >>> >>>>> > >>> >>>>> > >>> >>>>> > >>> > https://dist.apache.org/repos/dist/dev/mesos/0.28.0-rc1/mesos-0.28.0.tar.gz.asc > >>> >>>>> > >>> >>>>> > >>> >>>>> The PGP key used to sign the release is here: > >>> >>>>> > >>> >>>>> https://dist.apache.org/repos/dist/release/mesos/KEYS > >>> >>>>> > >>> >>>>> > >>> >>>>> The JAR is up in Maven in a staging repository here: > >>> >>>>> > >>> >>>>> > >>> https://repository.apache.org/content/repositories/orgapachemesos-1112 > >>> >>>>> > >>> >>>>> > >>> >>>>> Please vote on releasing this package as Apache Mesos 0.28.0! > >>> >>>>> > >>> >>>>> > >>> >>>>> The vote is open until Tue Mar 10 17:00:00 PST 2016 and passes > if a > >>> >>>>> majority of at least 3 +1 PMC votes are cast. > >>> >>>>> > >>> >>>>> > >>> >>>>> [ ] +1 Release this package as Apache Mesos 0.28.0 > >>> >>>>> > >>> >>>>> [ ] -1 Do not release this package because ... > >>> >>>>> > >>> >>>>> > >>> >>>>> Thanks, > >>> >>>>> > >>> >>>> > >>> >>>> > >>> >>> > >>> > > >>> > > >>> > > >>> > -- > >>> > ~Kevin > >>> > >>> > >>> > >>> -- > >>> ~Kevin > >>> > > > > -- > ~Kevin >
