I found two issues when compiling with clang 3.5: 1. The `-Wno-inconsistent-missing-override` option added in https://reviews.apache.org/r/67953/ is not recognized by clang 3.5. 2. The same issue described in https://reviews.apache.org/r/55400/ would make `src/resource_provider/storage/provider.cpp` fail to compile.
I put up two patches to resolve the above issues (no review posted yet): https://github.com/chhsia0/mesos/commit/1f60aa3b3a7eede4a2a5ddf1288efff6a801ea97 https://github.com/chhsia0/mesos/commit/84d13a0468f34726e4a920915cdda7e0e0a829b8 However, I'm not sure if this is worth blocking a release. We have 2 options: 1. Fail this vote and cut rc3 with the above patches to support clang 3.5. 2. Keep rc2 but bump the version requirement for clang on the website. (If so, then the above patches are not needed.) I was wondering which option would be more appropriate so I'd like to ask for some feedbacks. Thanks! On Wed, Aug 29, 2018 at 10:18 AM James Peach <jpe...@apache.org> wrote: > +1 (binding) > > Built and tested on Fedora 28 (clang). > > On Aug 24, 2018, at 4:42 PM, Chun-Hung Hsiao <chhs...@mesosphere.io> > wrote: > > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 1.7.0. > > > 1.7.0 includes the following: > > -------------------------------------------------------------------------------- > * Performance Improvements: > * Master `/state` endpoint: ~130% throughput improvement through > RapidJSON > * Allocator: Improved allocator cycle significantly > * Agent `/containers` endpoint: Fixed a performance issue > * Agent container launch / destroy throughput is significantly improved > * Containerization: > * **Experimental** Supported docker image tarball fetching from HDFS > * Added new `cgroups/all` and `linux/devices` isolators > * Added metrics for `network/cni` isolator and docker pull latency > * Windows: > * Added support to libprocess for the Windows Thread Pool API > * Multi-Framework Workloads: > * **Experimental** Added per-framework metrics to the master > * A new weighted random sorter was added as an alternative to the DRF > sorter > > The CHANGELOG for the release is available at: > > https://gitbox.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=1.7.0-rc2 > > -------------------------------------------------------------------------------- > > The candidate for Mesos 1.7.0 release is available at: > https://dist.apache.org/repos/dist/dev/mesos/1.7.0-rc2/mesos-1.7.0.tar.gz > > The tag to be voted on is 1.7.0-rc2: > https://gitbox.apache.org/repos/asf?p=mesos.git;a=commit;h=1.7.0-rc2 > > The SHA512 checksum of the tarball can be found at: > > https://dist.apache.org/repos/dist/dev/mesos/1.7.0-rc2/mesos-1.7.0.tar.gz.sha512 > > The signature of the tarball can be found at: > > https://dist.apache.org/repos/dist/dev/mesos/1.7.0-rc2/mesos-1.7.0.tar.gz.asc > > The PGP key used to sign the release is here: > https://dist.apache.org/repos/dist/release/mesos/KEYS > > The JAR is in a staging repository here: > https://repository.apache.org/content/repositories/orgapachemesos-1233 > > Please vote on releasing this package as Apache Mesos 1.7.0! > > The vote is open until Mon Aug 27 16:37:35 PDT 2018 and passes if a > majority of at least 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Mesos 1.7.0 > [ ] -1 Do not release this package because ... > > Thanks, > Chun-Hung & Gaston > > >
