I have posted patch-b in JIRA.

This patch does everything we want, and saves us having to write a separate
parser to parse the (from our point of view) broken findbugs.xml format that
findbugs-maven-plugin generates.

It also makes findbugs behave more like pmd and checkstyle, in that the
native XML report is generated by default.

Let us know what you think.

-Stephen Connolly

Garvin LeClaire-2 wrote:
> 
> It is an enhancement.
> 
> I do have on my list the ability to have multiple reports through
> delegates.
> I don't think Doxia allows this.
> 
> This will require some changes to Findbugs in order for me to also provide
> other items on the enhancement list such as timeouts.
> I am looking at the Findbugs code now to formulate my approach.
> 
> 
> 
> -- 
> Regards,
> 
> 
> Garvin LeClaire
> [EMAIL PROTECTED]
> On 8/9/07, Stephen Connolly <[EMAIL PROTECTED]> wrote:
>>
>>
>> Actually after further discusssions what we'd like is that the XML report
>> include the source paths that were added to the findbugs project when
>> findbugs was run.
>>
>> Where we've hit this is in writing a violations plugin for hudson
>> (https://hudson.dev.java.net)
>>
>> The XML report generated by findbugs-maven-plugin is a completely
>> different
>> schema from that generated by findbugs natively.
>>
>> One option would be for findbugs-maven-plugin to have the XDocsReporter
>> deligate to two reporters in parallel... thereby allowing delegation to
>> the
>> real findbugs xml reporter
>>
>> The other option is to have the FindbugsXdocSink just output an XML
>> element
>> which contains the list of source paths that maven knows about
>> (FindBugsMojo.addJavaSourcesToFindBugsProject)... this might be simpler
>> as
>> it would not break anyone who is assuming that the xml report is the
>> findbugs-maven-plugin format and not the findbugs format.
>>
>> I'll raise an issue in JIRA...
>>
>> is this:
>> 1. An enhancement (i.e. adding info to the xml report)
>> 2. A bug (i.e. the xml report is the wrong format)
>>
>> or can this be reassigned later.
>>
>> -Stephen
>>
>>
>> Garvin LeClaire-2 wrote:
>> >
>> > Put in a
>> > JIRA<
>> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=11062&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12112
>> >request
>> > for an enhancement.
>> >
>> >
>> >
>> > This is not a feature that has been in any of the past Maven
>> plugins.  We
>> > will need to make sure that we do not break any backwards
>> compatibility.
>> >
>> >
>> > --
>> > Regards,
>> >
>> >
>> > Garvin LeClaire
>> > [EMAIL PROTECTED]
>> >
>> >
>> > On 8/8/07, Stephen Connolly <[EMAIL PROTECTED]> wrote:
>> >>
>> >>
>> >> The XML report for findbugs-maven-plugin does not provide a link to
>> the
>> >> source file, only the class file.
>> >>
>> >> Is there anybody who could fix this... failing that I have no problem
>> >> developing a patch if necessary... just need to know to whom it should
>> >> go.
>> >>
>> >> -Stephen Connolly
>> >> --
>> >> View this message in context:
>> >> http://www.nabble.com/Findbugs-maven-plugin-tf4239159.html#a12062101
>> >> Sent from the mojo - user mailing list archive at Nabble.com.
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe from this list please visit:
>> >>
>> >>     http://xircles.codehaus.org/manage_email
>> >>
>> >>
>> >
>> >
>>
>> --
>> View this message in context:
>> http://www.nabble.com/Findbugs-maven-plugin-tf4239159.html#a12069489
>> Sent from the mojo - user mailing list archive at Nabble.com.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe from this list please visit:
>>
>>     http://xircles.codehaus.org/manage_email
>>
>>
> 
> 

-- 
View this message in context: 
http://www.nabble.com/Findbugs-maven-plugin-tf4239159.html#a12095489
Sent from the mojo - user mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to