Rahul Thakur wrote:
I would like to call for a vote to release 1.0.
0, not using it. The notes:
Strangely, the POM declares the plugin's version as 1.2-SNAPSHOT.
The POM is inhering from a very old Mojo parent, thereby producing an
irreproducible build and wrong mailing list info. Note that inheriting
from mojo-parent:18 will require to configure the source/target for the
Compiler Plugin directly instead of using the sys props.
The POM is missing the <description> and <prerequisites> elements (c.f.
output from "mvn docck:check"). In particular, the project has several
dependencies on artifacts from Maven 2.0.9. It's recommended to sync the
Maven version stated by the prerequisites with the versions used for the
dependencies.
The <organization> element is superfluous since inherited. Especially,
the organization's URL is not the plugin site but the Codehaus homepage.
The project/scm/url could alternatively be pointed to the FishEye URL of
the plugin for nicer browsing:
http://fisheye.codehaus.org/browse/mojo/trunk/mojo/openjpa-maven-plugin
The site descriptor could be updated/trimmed as well when inheriting
from latest Mojo parent. I.e. remove name="[...]", banners, links and
reports (c.f. [0]).
Also, the site doesn't comply with the plugin documentation standard
[1]. For instance, the index page is completely empty and the menu bar
has no link to the goal documentation.
The example POM snippet on the usage page doesn't show a <version>
element for the plugin, thereby promoting bad practices to the user.
Is the reference to the Apache's Incubator repository still required?
Just wondering because at least the plugin's dependencies were all
satisfied from central.
A couple of Checkstyle/PMD issues regarding code formatting and unused
imports.
There are some discrepancies with the plugin's dependencies as reported
by "mvn dependency:analyze".
The parameters "includes" and "excludes" in AbstractOpenJpaMojo.java
could employ the Mojo annotation default-value instead of duplicating
the value in the variable initialization and parameter doc.
Likewise, the default value for the parameter outputDirectory is better
specified via default-value="" instead of expression="".
The string-typed parameters schemaFile in OpenJpaSchemaMojo.java and
sqlFile in OpenJpaSqlMojo are subject to a common bug [2].
Benjamin
[0]
http://mojo.codehaus.org/development/guidelines.html#Plugin_Site_Template
[1]
http://maven.apache.org/guides/development/guide-plugin-documentation.html
[2]
http://maven.apache.org/plugin-developers/common-bugs.html#Resolving_Relative_Paths
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
