Hi,
thanks for the patches.
A few remarks: Even though JDK6 has reached EOL, Mavens requirement is
still JDK5.
So for MEXEC-121 you need to check if java.io.Console is available, since
it was introduced with Java6
In both cases it would be nice to add an integration test, based on the
maven-invoker-plugin[1], to confirm your solution.
There are already several tests under src/it
Run 'mvn verify' to confirm that everything still works.
thanks,
Robert
[1] http://maven.apache.org/plugins/maven-invoker-plugin/
Op Sat, 04 Jan 2014 23:54:59 +0100 schreef Trask Stalnaker
<trask.stalna...@gmail.com>:
Hi,
I have submitted 2 patches to the maven-exec-plugin project. What's the
best way to help move these forward?
http://jira.codehaus.org/browse/MEXEC-118
http://jira.codehaus.org/browse/MEXEC-121
Thanks,
Trask
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
