I read this issue and I agree with Ferdy and Julien about adding host ip to metadata instead of http header. But I have a couple of questions:

1- when protocol is any other protocol than HTTP it doesn't make sense property name was named http.store.ip.adress.in my opinion it doesn't general name. maybe we can name it store.ip.address and other protocols can implement this one. What do you think about it?

2- Don't we already have the IP of connected host when we establish socket connection? Why do we need to add IP in HTTP GET request? Is it because initially connected host IP and fetched host IP may be different?

Thanks

On 25-10-2013 00:08, Lewis John Mcgibbney wrote:
Hi Yasin & Julien,

On Thu, Oct 24, 2013 at 8:06 PM, <[email protected]> wrote:


add it to the metadata at the protocol level. Have you checked that there
isn't a patch for that in Jira? If not please create one

Yeah there is a patch for this which has stagnated somewhat.
You can find it here
https://issues.apache.org/jira/browse/NUTCH-1360
If you are able to test this out then please do so. It would be nice to get
it in to both branches.
Thanks
Lewis


Reply via email to