Can someone tell me the svn command to create a patch? If so, I'll submit it today.
Skip -----Original Message----- From: Jacques Le Roux [mailto:[EMAIL PROTECTED] Sent: Saturday, October 20, 2007 5:26 AM To: [email protected] Subject: Re: Bug in add party notes Hi Skip, De : "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> > Log into webtools. Click on Party tab. Click on "Find..." at the bottom > with all the fields blank. Select "DemoCustCompany" [Details] > > At the very bottom of the page, click "Create New" in the notes area. > > In the next screen, enter a noteId and note and click save at the bottom. > You get this error: > > ... > [noteId,DemoNote1(java.lang.String)][partyId,DemoCustCompany(java.lang.Strin > g)] ... INSERT on table 'PARTY_NOTE' caused a violation of foreign key > constraint 'PARTY_NOTE_NOTE' for key (DemoNote1). > > .... > > org.ofbiz.party.party.PartyServices.createPartyNote(PartyServices.java:631) > > > If you look at the code referenced, you will note that if the "Note Id" > field is left blank, the NoteData entry is created and everything works > fine. > > > It is my view that createPartyNote() should be modified to check to see if > the NoteData exists if a noteId is passed and if not, one should be created > or else the Note id field should be removed from (or passed as hidden) the > note creation screen. Yes I agree, this is a solution > I don't actually understand why the user would be asked to enter a noteId > anyway. Maybe to allow user to set itself his/her notes number for recall later ? But then it should not be a primary key (which should be generated) or it should be checked in code (as for Product for instance) > I can fix this and submit a patch, but I wanted to be sure I wasn't missing > something. Please feel free to submit a patch Thanks Jacques > Skip >
