On Feb 2, 2009, at 9:33 AM, Adrian Crum wrote:
You made a good point about the naming convention used in the
layoutSettings Map. We could modify the theme services to convert
the enum IDs to the Java naming convention. Perhaps you could get a
discussion going on the dev mailing list for that.
Actually I think this part is fine too. Those are ID values and not
variable names. In most of OFBiz we use the this pattern rather than
Java naming conventions.
-David
BJ Freeman wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
1) the themes has a folder outside of framework or specialpurpose.
Believe it should be in framework/common/webcommon/themes
2) the java convention is not used for say VT_SHORTCUT_ICON instead
of
being vtShortcutIcon
3) VT_SHORTCUT_ICON is used as a <Enumeration enumId so should not
be
used as a variable.
4)if an application uses headerTemplateLocation then it is overridden
<set field="headerTemplateLocation"
from-field="layoutSettings.VT_HDR_TMPLT_LOC[0]"
default-value="component://common/webcommon/includes/header.ftl"/>
so the purpose of headerTemplateLocation is defeated.
the same for
footerTemplateLocation
appbarTemplateLocation
messagesTemplateLocation
5)having moved the location of the headerTemplateLocation to the
entity
VisualThemeResource without providing ways of custom application the
standard way to pass this information breaks the model.
Jacques Le Roux sent the following on 2/2/2009 2:18 AM:
Could you elaborate you POV, please ?
Jacques
From: "BJ Freeman" <[email protected]>
I am johnny come lately, so it looks like themes came in the back
door
and has circumvented the ofbiz coding practices and framework
instead of
enhancing it.
Jacques Le Roux sent the following on 2/2/2009 12:36 AM:
http://docs.ofbiz.org/display/OFBIZ/Visual+Themes+-+How+to
A bit deprecated but still usable. But I wonder if people are
aware of
the wiki search feature :p
Jacques
From: "BJ Freeman" <[email protected]>
is there a wiki that shows how to use the visual themes?
Enrique Ruibal A. sent the following on 2/1/2009 3:12 PM:
Hi,
Try First changing tha field value for VT_HDR_IMAGE_URL it
is set by
default to the field value of RESOURCE_VALUE as
/images/ofbiz_logo.jpg
on the visual_theme_resource_table.
Put your own image name and path there and see what happens
afterwards.
Regards,
-Enrique Ruibal
G. Michael Jean wrote:
Hi,
I made a new logo - same size and type as the default
ofbiz_logo.jpg.
When I copy this new logo to
/path/to/ofbiz/framework/images/webapp/images and then
rename the
file
ofbiz_logo.jpg then it is displayed successfully.
I decided to try to do this a little more intelligently and
so I
changed
the instances of text "ofbiz_logo.jpg" in
/path/to/ofbiz/framework/common/widget/CommonScreens.xml to
the
filename
I created but it still displays the old logo. Does anyone
know why?
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFJhttxrP3NbaWWqE4RAuAVAJ0ZmdIvbuzuCjEYxDcGQ2dBmCD4DwCcCsiF
Y00R8giFf3+WoWYn+u7dd8E=
=+KUx
-----END PGP SIGNATURE-----
