Hi All

Thanks for the help on my previous question.

When we close an accounting period the simpe method "closeFinancialTimePeriod" 
in GeneralLedgerServices.xml uses a less than operator to select figures to 
include in closing the period. However when accounting are created and written 
to acctg_trans_entry a less than or equals is used in simple-method 
"findCustomTimePeriods" ( called by "postAcctgTrans"  ) to select the time 
period for the transaction. 

This means that figures writting on the closing day are missed when the 
accounts are closed. 

Please can anyone comment on my understanding.

Cheers
Rees


"closeFinancialTimePeriod" - in GeneralLedgerServices.xml 
        <entity-condition entity-name="AcctgTransAndEntries" 
list-name="acctgTransAndEntries">
            <condition-list combine="and">
                <condition-expr field-name="organizationPartyId" 
operator="equals" env-name="customTimePeriod.organizationPartyId"/>
                <condition-expr field-name="isPosted" operator="equals" 
value="Y"/>
                <condition-expr field-name="glFiscalTypeId" operator="equals" 
value="ACTUAL"/>
                <condition-expr field-name="transactionDate" 
operator="greater-equals" env-name="lastClosedDate"/>
                <condition-expr field-name="transactionDate" operator="less" 
env-name="customTimePeriod.thruDate"/> <!-- FIXME: Date to Timestamp -->
                <condition-expr field-name="acctgTransTypeId" 
operator="not-equals" value="PERIOD_CLOSING"/>
                <condition-list combine="or">
                    <condition-expr field-name="glAccountClassId" operator="in" 
env-name="expenseAccountClassIds"/>
                    <condition-expr field-name="glAccountClassId" operator="in" 
env-name="revenueAccountClassIds"/>
                    <condition-expr field-name="glAccountClassId" operator="in" 
env-name="incomeAccountClassIds"/>
                </condition-list>
            </condition-list>
            <order-by field-name="acctgTransId"/>
            <order-by field-name="acctgTransEntrySeqId"/>
        </entity-condition>

PeriodServices.xml
            <iterate entry-name="curOrganizationPartyId" 
list-name="parentOrganizationPartyIdList">
                <clear-field field-name="orgTimePeriodList"/>
                <entity-condition entity-name="CustomTimePeriod" 
list-name="orgTimePeriodList">
                    <condition-list combine="and">
                        <condition-list combine="or">
                            <condition-expr field-name="organizationPartyId" 
operator="equals" env-name="curOrganizationPartyId"/>
                        </condition-list>
                        <condition-expr field-name="fromDate" 
operator="less-equals" env-name="parameters.findDate"/>
                        <condition-list combine="or">
                            <condition-expr field-name="thruDate" 
operator="greater-equals" env-name="parameters.findDate"/>
                            <condition-expr field-name="thruDate" 
operator="equals" env-name="nullField"/>
                        </condition-list>
                        <condition-expr field-name="periodTypeId" operator="in" 
env-name="parameters.onlyIncludePeriodTypeIdList" ignore-if-empty="true"/>
                    </condition-list>
                </entity-condition>
                <list-to-list list-name="orgTimePeriodList" 
to-list-name="listSoFar"/>                                
            </iterate>
        </if-not-empty>


      

Reply via email to