Thanks Torstein, although I probably should have sent you to this page: http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices as it contains details on how to create a patch (diff) file under the section: How to Send in Your Contributions (or how to create and apply patches)

Most committers won't look at a modified file because it is too difficult to figure out what changes have been made and to what revision of the file.

Regards
Scott

On 20/05/2009, at 12:18 AM, Torstein Hegbom wrote:

Please see OFBIZ-2493, where I have added suggested fixes.

Torstein

-----Opprinnelig melding-----
Fra: Scott Gray [mailto:[email protected]]
Sendt: 19. mai 2009 13:54
Til: [email protected]
Emne: Re: SV: A stupid question

Wise choice, fortune favors the bold :-)

If you do decide to submit some fixes don't be disheartened if they
don't make it in straightaway, it all just depends on when someone has
the time (and inclination) to look at it.

Regards
Scott

On 19/05/2009, at 11:45 PM, Torstein Hegbom wrote:

#1 if I may. I have done one fix fore the web-store, but in the
productsummary.ftl in product and ecommerce. I thought that it just
me who
have observed this. May be I should be as bold to suggest a fix or
two.

Torstein

-----Opprinnelig melding-----
Fra: Ashish Vijaywargiya [mailto:[email protected]]
Sendt: 19. mai 2009 13:40
Til: [email protected]
Emne: Re: A stupid question

#1 is the preferred option, but at the end of the day it all
depends on
how involved with the community you want to be :-)

:-)

--
Ashish

On Tue, May 19, 2009 at 4:49 PM, Scott Gray
<[email protected]>wrote:

Hi Torstein

If you can reproduce it on the demo server then yes it is a
problem.  For
what to do about it, you have 3 options:
1.  Create a Jira issue and submit a patch to fix it.
2.  Create a Jira issue and wait for someone else to fix it.
3.  Do nothing and enjoy it as is.

#1 is the preferred option, but at the end of the day it all
depends on
how
involved with the community you want to be :-)

Regards
Scott






Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to