I will give you a general answer to all you statements. this is a community effort. the people that answer on the mailing list do so as a volunteers, not as a paid support person. You may have a valid point. Don't expect a response if you don't want to follow the guidelines that have been setup. even if you do follow the guidelines don't expect a response. they ones that might try to work with you, will require you describe in a way that will take the least amount of time for them.
when you get to the place where you can open Jiras and provide patches, then become familiar with the contribution. http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices Cimballi sent the following on 5/29/2009 8:39 PM: > Well, I don't know how to explain you, it seems evident to me... > In the first case you check if "productStore" is null or not. In the > second case, you don't check. > So, what is the correct behaviour ? Should an order be linked to a > productStore or not ? > If yes, why the first test ? > If no, there is missing a test in the second case. > >>From my point of view I would say no because an order with products of > type "service" don't need productStore. > > To Scott : you should consider there are different kind of > contributors on open source projects, I'm the kind of contributor who > send emails when I find something I think is a bug, I'm still not in > the category of "patch providers" ! :-) > > Cimballi > > > On Fri, May 29, 2009 at 7:16 PM, Scott Gray <[email protected]> > wrote: >> Hi Cimballi >> >> Inconsistencies aren't necessarily bugs, but you are most welcome to create >> a patch and jira issue for the corrections you think should be made. >> >> Thanks >> Scott >> >> On 30/05/2009, at 10:39 AM, Cimballi wrote: >> >>> Hi, >>> >>> There are several inconsistancies in the file >>> >>> "applications/order/webapp/ordermgr/WEB-INF/actions/order/OrderView.groovy". >>> >>> I didn't note all of them, but here is an example : >>> >>> Line 260, productStore can be null : >>> productStore = orderHeader.getRelatedOne("ProductStore"); >>> if (productStore) { >>> facility = productStore.getRelatedOne("Facility"); >>> >>> Line 380, here productStore cannot be null : >>> productStoreId = >>> orderHeader.getRelatedOne("ProductStore").productStoreId; >>> >>> Cimballi >> > -- BJ Freeman http://www.businessesnetwork.com/automation http://bjfreeman.elance.com http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro Systems Integrator.
