Yes you are right .. but in my case its not a problem as we don't put any files into hot-deploy, but only the symbolic link, but here again symbolic link is also a file, but then we don't commit code to ofbiz svn but always customise it into our custom component.
But for people who commits to ofbiz, this will be a good change, I guess. +1 from my side .. :) On Wed, Sep 9, 2009 at 5:33 PM, Ashish Vijaywargiya < [email protected]> wrote: > You have missed one important point. > What would be the case if we have files in hot-deploy directory that is not > associated with any version control system? > > Anyone can accidentally commit those files. > > -- > Ashish > > On Wed, Sep 9, 2009 at 5:12 PM, Abdullah Shaikh < > [email protected]> wrote: > > > Just FYI, I dont know if this makes sense for this conversation. We have > a > > separate svn path for ofbiz and custom component, what I do is create a > > symbolic link of my custom component into hot-deploy folder, this way > there > > are no issues of a code being committed to ofbiz because ofbiz & custom > > component are into separate folders. > > > > > > On Wed, Sep 9, 2009 at 4:07 PM, Vikas Mayur <[email protected] > > >wrote: > > > > > Hi Scott, > > > > > > Thanks for the stating this clearly (I see now that I haven't proposed > > > enough reason(s) to support my question) and yes I have the same > feeling > > of > > > committing custom code accidently. > > > > > > Most of the time I also have a tar file of the custom component under > > > hot-deploy directory, as instead taking a fresh checkout for a > component > > > (which contains images in GB) I prefer to take archive file > > > > > > from someone who already have a checkout. > > > > > > Though to commit something from hot-deploy, the custom component or > file > > > need to added to version control first. This is obviously a first > check. > > > > > > I tried to add the custom component to version control but since my > > custom > > > component is also version controlled, it denied to add this again to > > > hot-deploy so this was safe. > > > > > > But what if custom work/component is not under version control, there > are > > > still chances of errors and code being accidently committed to trunk. > > > > > > I think this reason should be enough to ignore the hot-deploy folder. > > > > > > Vikas > > > > > > > > > On Sep 9, 2009, at 2:59 PM, Scott Gray wrote: > > > > > > I guess what Vikas hasn't explained is the reason why he wants the > > >> hot-deploy folder's contents to be ignored. > > >> > > >> The answer to that I guess is fairly obvious, the hot-deploy folder is > a > > >> place to put custom applications and code and when you put code in > there > > svn > > >> treats it as a change to the OFBiz svn. The is a constant risk of > > >> accidentally committing an entire body of custom work to the OFBiz > repo. > > >> > > >> Is that your reason for bringing it up Vikas? I have to admit I have > > >> performed many nervous commits with the fear that my work is going to > > the > > >> wrong repository. > > >> > > >> Regards > > >> Scott > > >> > > >> On 9/09/2009, at 9:11 PM, Jacques Le Roux wrote: > > >> > > >> Hi Vikas, > > >>> > > >>> From: "Vikas Mayur" <[email protected]> > > >>> > > >>>> Hi Jacques, > > >>>> I do not see any problems because I am not a SVN Guru. I was just > > >>>> trying to understand why it is not ignored. AFAIK this directory is > > not > > >>>> used for any other purpose other then adding your custom component. > > >>>> Does only readme file under this directory adds to a good reason of > > not > > >>>> ignoring this? > > >>>> > > >>> > > >>> If nobody has any problems with it I would say, yes keep it as is. > > Other > > >>> opininons ? > > >>> > > >>> Jacques > > >>> > > >>>> Vikas > > >>>> On Sep 8, 2009, at 7:09 PM, Jacques Le Roux wrote: > > >>>> > > >>>>> Hi Vikas, > > >>>>> > > >>>>> I'd prefer to keep it there. What is your problem with svn:ignore ? > > >>>>> > > >>>>> Jacques > > >>>>> > > >>>>> From: "Vikas Mayur" <[email protected]> > > >>>>> > > >>>>>> Hi Scott, > > >>>>>> Thanks for your reply, though it was the easiest one :) > > >>>>>> Do you agree that hot-deploy folder should be ignored and readme > > file > > >>>>>> is moved to under some other directory or even its contents > merged > > with > > >>>>>> README file under root folder, or any other better option? > > >>>>>> Vikas > > >>>>>> On Sep 8, 2009, at 5:46 PM, Scott Gray wrote: > > >>>>>> > > >>>>>>> Hi Vikas > > >>>>>>> > > >>>>>>> The only reason I can think of is the readme file. > > >>>>>>> > > >>>>>>> Regards > > >>>>>>> Scott > > >>>>>>> > > >>>>>>> HotWax Media > > >>>>>>> http://www.hotwaxmedia.com > > >>>>>>> > > >>>>>>> On 9/09/2009, at 12:11 AM, Vikas Mayur wrote: > > >>>>>>> > > >>>>>>> Hi, > > >>>>>>>> > > >>>>>>>> Does anyone know why svn:ignore is not set to TRUE on hot-deploy > > >>>>>>>> folder? > > >>>>>>>> > > >>>>>>>> Thanks, > > >>>>>>>> Vikas > > >>>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > > >
