Thanks Jacques. Yes opinions please .. On Thu, Nov 19, 2009 at 4:32 PM, Jacques Le Roux < [email protected]> wrote:
> I did it but not in http (only in base/lib) maybe I should (before I update > allrelated files...) ? Opinions ? > > > Jacques > > From: "Abdullah Shaikh" <[email protected]> > >> Opening a jira issue for adding http jars into framework/base/lib folder, >> I >> guess we should have a "http" folder inside lib. >> >> There are already beta versions available in framework/testools/lib, its >> better to remove these jars from testtools and put in base/lib/http >> replacing them with release version. >> >> -Abdullah >> >> On Tue, Nov 3, 2009 at 11:33 PM, Jacques Le Roux < >> [email protected]> wrote: >> >> OK, it was not clear to me, thanks >>> If it's done the same way other gateways are implement I can't see any >>> issue using httpcomponents-client-4.0, and yes it should be located >>> framework/base/lib. >>> I suggest to open a Jira >>> >>> >>> Jacques >>> >>> From: "Abdullah Shaikh" <[email protected]> >>> >>> Hi Jacques, >>>> >>>> I didn't get you .... If you meant any sagepay code is involved, then >>>> its >>>> not, I have implemented it same as any other payment gateways are >>>> integrated >>>> in ofbiz, for example authorize.net. >>>> >>>> On Tue, Nov 3, 2009 at 10:50 PM, Jacques Le Roux < >>>> [email protected]> wrote: >>>> >>>> But isn't the SagePay payment gateway licence commercial ? >>>> >>>>> >>>>> Jacques >>>>> >>>>> From: "Abdullah Shaikh" <[email protected]> >>>>> >>>>> I have integrated SagePay payment gateway into ofbiz accounting >>>>> component, >>>>> >>>>> which I would like to contribute. >>>>>> >>>>>> For this I have used Apache httpcomponents-client-4.0, is it ok ? >>>>>> >>>>>> I have choose to use httpcomponent because it is easy to send >>>>>> parameters >>>>>> & >>>>>> fetch response from the gateway, compared to using Socket class, and >>>>>> manually forming string and parsing the response string. >>>>>> >>>>>> If its ok then we can add the httpcomponents to the framework/base/lib >>>>>> folder, currently I have added the jar in accounting/lib. >>>>>> >>>>>> Regards, >>>>>> Abdullah >>>>>> http://www.viithiisys.com >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >>> >> >
