+1. As another newcomer to Java, I appreciate the knowledge and patience of those here. There is a lot to assimilate, and while I've been around the block a time or two before, I am definitely a newbie on this block, and it is not only a new language (actually several) but a whole new development environment as well.
The quality of the code seems very high, and the thought behind this system has always impressed me. I look forward to learning more. Thanks again. -- Matt Warnock <[email protected]> RidgeCrest Herbals, Inc. On Thu, 2010-05-27 at 22:13 -0400, Ruth Hoffman wrote: > Hi Adrian: > One other thing I'd like to say here, if you care to listen: > > I grew up writing IBM Assembler and Fortran code so Java is relatively > new to me. With Java, I'm self taught and most of what I've come to know > and love about it I've learned through studying OFBiz. > > I want to thank you and all the OFBiz Java developers out there for > making OFBiz a showcase of Java "best practices" and giving me the > opportunity to learn from the best. Troubleshooting my problem taught me > yet more about Java. I love that there is always something new and > interesting here. So, thanks again. > > Sincerely, > Ruth > > Adrian Crum wrote: > > The problem was resolved and she thanked us. I'm satisfied. > > > > -Adrian > > > > --- On Thu, 5/27/10, Hans Bakker <[email protected]> wrote: > > > > > >> From: Hans Bakker <[email protected]> > >> Subject: Re: How to I overcome this error? > >> To: [email protected] > >> Date: Thursday, May 27, 2010, 6:06 PM > >> Wouldn't apologies from someone > >> presenting herself as an expert and > >> causing so much work for several people be nice here? > >> > >> > >> On Thu, 2010-05-27 at 13:20 -0400, Ruth Hoffman wrote: > >> > >>> Hi Tim: > >>> I just did it again and you and Adrian are correct. It > >>> > >> is not in there... > >> > >>> Thanks for your help. > >>> Regards, > >>> Ruth > >>> > >>> Tim Ruppert wrote: > >>> > >>>> Here are those same two methods that I got from > >>>> > >> the download > >> > >>>> -- NOTE I see no "// @Override" > >>>> > >>>> // ----- > >>>> > >> TemporalExpressionVisitor Implementation ----- // > >> > >>>> public void > >>>> > >> visit(Difference expr) { > >> > >>>> > >>>> > >> VisitorState newState = new > >> VisitorState(); > >> > >>>> > >>>> > >> newState.isIntersection = > >> this.state.isIntersection; > >> > >>>> > >>>> > >> this.stateStack.push(this.state); > >> > >>>> this.state > >>>> > >> = newState; > >> > >>>> > >>>> > >> expr.getIncluded().accept(this); > >> > >>>> > >>>> > >> newState.isExcluded = true; > >> > >>>> > >>>> > >> expr.getExcluded().accept(this); > >> > >>>> this.state > >>>> > >> = this.stateStack.pop(); > >> > >>>> if > >>>> > >> (this.state.isIntersection) { > >> > >>>> > >>>> > >> this.state.inclRecurList.addAll(newState.inclRecurList); > >> > >>>> > >>>> > >> this.state.exRecurList.addAll(newState.exRecurList); > >> > >>>> } > >>>> } > >>>> > >>>> > >>>> > >> @SuppressWarnings("unchecked") > >> > >>>> public void > >>>> > >> visit(HourRange expr) { > >> > >>>> NumberList > >>>> > >> hourList = new NumberList(); > >> > >>>> > >>>> > >> hourList.addAll(expr.getHourRangeAsSet()); > >> > >>>> Recur recur > >>>> > >> = new Recur(Recur.HOURLY, 0); > >> > >>>> > >>>> > >> recur.getHourList().addAll(hourList); > >> > >>>> > >>>> > >> this.state.addRecur(recur); > >> > >>>> } > >>>> > >>>> Hope this helps Ruth. > >>>> > >>>> Cheers, > >>>> Ruppert > >>>> > >>>> On May 27, 2010, at 10:46 AM, Adrian Crum wrote: > >>>> > >>>> > >>>> > >>>>> It would be interesting to see if anyone else > >>>>> > >> can find those annotations in that download. I certainly > >> can't. > >> > >>>>> -Adrian > >>>>> > >>>>> On 5/27/2010 9:27 AM, Ruth Hoffman wrote: > >>>>> > >>>>> > >>>>>> Hi Adrian: > >>>>>> They may not be in SVN, but they > >>>>>> > >> certainly are in this download. I just > >> > >>>>>> double checked: > >>>>>> > >>>>>> http://apache.multihomed.net/ofbiz/apache-ofbiz-09.04.zip > >>>>>> > >>>>>> Regards, > >>>>>> Ruth > >>>>>> > >>>>>> Adrian Crum wrote > >>>>>> > >>>>>> > >>>>>>> I checked the 9.04 release zip file > >>>>>>> > >> and the repository - those > >> > >>>>>>> annotations do not exist in 9.04. > >>>>>>> > >> They were removed last March - so > >> > >>>>>>> maybe you are using an old download. > >>>>>>> > >> At any rate, the problem doesn't > >> > >>>>>>> exist in current code. > >>>>>>> > >>>>>>> -Adrian > >>>>>>> > >>>>>>> On 5/27/2010 8:57 AM, Ruth Hoffman > >>>>>>> > >> wrote: > >> > >>>>>>> > >>>>>>> > >> > >> > >>>>>>>> Hi Adrian: > >>>>>>>> > >>>>>>>> I just downloaded the 9.04 > >>>>>>>> > >> release from the download site and these > >> > >>>>>>>> lines are in the > >>>>>>>> > >> iCalRecurConverter.java source starting at line 124: > >> > >>>>>>>> @Override > >>>>>>>> public void visit(Difference > >>>>>>>> > >> expr) { > >> > >>>>>>>> VisitorState newState = new > >>>>>>>> > >> VisitorState(); > >> > >>>>>>>> newState.isIntersection = > >>>>>>>> > >> this.state.isIntersection; > >> > >> this.stateStack.push(this.state); > >> > >>>>>>>> this.state = newState; > >>>>>>>> expr.getIncluded().accept(this); > >>>>>>>> ... > >>>>>>>> > >>>>>>>> Thanks. > >>>>>>>> Regards > >>>>>>>> Ruth > >>>>>>>> > >>>>>>>> Adrian Crum wrote: > >>>>>>>> > >>>>>>>> > >> > >> > >>>>>>>>> Where are you getting that > >>>>>>>>> > >> file from? Those annotations are not in > >> > >>>>>>>>> 9.04. > >>>>>>>>> > >>>>>>>>> -Adrian > >>>>>>>>> > >>>>>>>>> On 5/27/2010 8:40 AM, Ruth > >>>>>>>>> > >> Hoffman wrote: > >> > >>>>>>>>> > >>>>>>>>> > >> > >> > >>>>>>>>>> Hi Adrian: > >>>>>>>>>> Here you go...a partial > >>>>>>>>>> > >> listing from recent 9.04 > >> > >>>>>>>>>> iCalRecurConverter.java > >>>>>>>>>> (with my comments) > >>>>>>>>>> > >> source: > >> > >>>>>>>>>> // ----- > >>>>>>>>>> > >> TemporalExpressionVisitor Implementation ----- // > >> > >>>>>>>>>> // @Override > >>>>>>>>>> public void > >>>>>>>>>> > >> visit(Difference expr) { > >> > >>>>>>>>>> VisitorState newState = > >>>>>>>>>> > >> new VisitorState(); > >> > >>>>>>>>>> newState.isIntersection = > >>>>>>>>>> > >> this.state.isIntersection; > >> > >> this.stateStack.push(this.state); > >> > >>>>>>>>>> this.state = newState; > >>>>>>>>>> > >>>>>>>>>> > >> expr.getIncluded().accept(this); > >> > >>>>>>>>>> newState.isExcluded = > >>>>>>>>>> > >> true; > >> > >> expr.getExcluded().accept(this); > >> > >>>>>>>>>> this.state = > >>>>>>>>>> > >> this.stateStack.pop(); > >> > >>>>>>>>>> if > >>>>>>>>>> > >> (this.state.isIntersection) { > >> > >> this.state.inclRecurList.addAll(newState.inclRecurList); > >> > >> this.state.exRecurList.addAll(newState.exRecurList); > >> > >>>>>>>>>> } > >>>>>>>>>> } > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >> @SuppressWarnings("unchecked") > >> > >>>>>>>>>> // @Override > >>>>>>>>>> public void > >>>>>>>>>> > >> visit(HourRange expr) { > >> > >>>>>>>>>> NumberList hourList = new > >>>>>>>>>> > >> NumberList(); > >> > >> hourList.addAll(expr.getHourRangeAsSet()); > >> > >>>>>>>>>> Recur recur = new > >>>>>>>>>> > >> Recur(Recur.HOURLY, 0); > >> > >> recur.getHourList().addAll(hourList > >> > >>>>>>>>>> ... > >>>>>>>>>> TIA > >>>>>>>>>> Ruth > >>>>>>>>>> Adrian Crum wrote: > >>>>>>>>>> > >>>>>>>>>> > >> > >> > >>>>>>>>>>> On 5/27/2010 4:18 AM, > >>>>>>>>>>> > >> Ruth Hoffman wrote: > >> > >>>>>>>>>>> > >>>>>>>>>>> > >> > >> > >>>>>>>>>>>> (Ended up just > >>>>>>>>>>>> > >> commenting out the offending lines in the code.) > >> > >>>>>>>>>>>> > >>>>>>>>>>>> > >> > >> > >> > >>>>>>>>>>> I would be interested > >>>>>>>>>>> > >> in seeing what those offending lines are. > >> > >>>>>>>>>>> Like I > >>>>>>>>>>> said in my previous > >>>>>>>>>>> > >> reply, there are no @Override annotations in the > >> > >>>>>>>>>>> 9.04 version of that > >>>>>>>>>>> > >> file. > >> > >>>>>>>>>>> -Adrian > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >> > >> > >>>> > >>>> > >> -- > >> Ofbiz on twitter: http://twitter.com/apache_ofbiz > >> Myself on twitter: http://twitter.com/hansbak > >> Antwebsystems.com: Quality services for competitive rates. > >> > >> > >> > > > > > > > > > >
