createShoppingListItem logically doesn't require a login but it then checks
for checkShoppingListItemSecurity and here it falls out because of the
security.

I see 2 problem :

1) createShoppingListitem if can be accessed without login then it should
not check for security later on.
2) While adding a new item to shopping cart, setQuantity method of
ShoppingCartItem calls ShoppingListEvents.fillAutoSaveList(cart,
dispatcher); IMHO it should only be called if user is logged in.



On Tue, Jun 19, 2012 at 1:12 AM, Jacques Le Roux <
[email protected]> wrote:

> Thanks for the detailled report Bhargav,
>
> I was able to reproduce locally, I will have a deeper look when I will get
> a chance. But I already believe it's not related to shopping lists.
> It's just that Product.groovy does not get a productId in this case (when
> called from <screen name="product"> )
>
> Jacques
>
> From: "bhargav.tri" 
> <Bhargav.Trivedi@objectedge.**com<[email protected]>
> >
>
>  Thank you for looking into this Jacques and excuse me for the late reply.
>>
>> But I am able to recreate the scenario for the same widget but I am going
>> to
>> product detail page first
>> (http://demo-trunk.ofbiz.**apache.org:8080/ecommerce/**
>> tiny-chrome-widget-WG-5569-p<http://demo-trunk.ofbiz.apache.org:8080/ecommerce/tiny-chrome-widget-WG-5569-p>
>> )
>> and then adding the item to cart.
>>
>> After this when I login with DemoCustomer/ofbiz I see "Product not found
>> for
>> Product ID !"
>>
>> Also I am redirected to
>> https://demo-trunk.ofbiz.**apache.org:8443/ecommerce/**
>> control/checkLogin/product<https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/checkLogin/product>
>>
>> Secondly to answer this,
>> /Could you explain more
>>
>>> I looked into the logs for my website and I think it is because we are
>>> linking a product with users shipping list. /
>>>
>>
>> I came across the same error in my website and this is what I see in my
>> error console;
>>
>> /2012-06-15 18:46:03,122 (http-0.0.0.0-8443-6) [
>> ShoppingListEvents.java:374:**INFO ] Finding existing auto-save shopping
>> list
>> with:
>> findMap: {partyId=10000, productStoreId=MyStore,
>> shoppingListTypeId=SLT_SPEC_**PURP, listName=auto-save}
>> lists:
>> {[GenericEntity:ShoppingList][**carrierPartyId,null()][**
>> carrierRoleTypeId,null()][**contactMechId,null()][**
>> createdStamp,2012-03-15
>> 14:46:31.0(java.sql.Timestamp)**][createdTxStamp,2012-03-15
>> 14:46:31.0(java.sql.Timestamp)**][currencyUom,null()][**
>> description,null()][isActive,**Y(java.lang.String)][isPublic,**
>> N(java.lang.String)][**lastAdminModified,null()][**
>> lastOrderedDate,null()][**lastUpdatedStamp,2012-03-15
>> 14:46:31.0(java.sql.Timestamp)**][lastUpdatedTxStamp,2012-03-**15
>> 14:46:31.0(java.sql.Timestamp)**][listName,auto-save(java.**
>> lang.String)][**parentShoppingListId,null()][**partyId,10000(java.lang.**
>> String)][paymentMethodId,null(**)][productPromoCodeId,null()][**
>> productStoreId,AutogozaStore(**java.lang.String)][**
>> recurrenceInfoId,null()][**shipmentMethodTypeId,null()][**
>> shoppingListId,10000(java.**lang.String)][**shoppingListTypeId,SLT_SPEC_*
>> *PURP(java.lang.String)][**visitorId,null()]}
>> 2012-06-15 18:46:03,140 (http-0.0.0.0-8443-6) [
>> ShoppingListEvents.java:147:**INFO ] Adding cart item to shopping list
>> [10000], allowPromo=false, item.getIsPromo()=false,
>> item.getProductId()=10-**1010012-B1, item.getQuantity()=1.00
>> 2012-06-15 18:46:03,146 (http-0.0.0.0-8443-6) [
>> ServiceEcaRule.java:134:INFO ] For Service ECA [createShoppingListItem] on
>> [in-validate] got false for condition:
>> [shoppingListId][is-empty][**true][String]
>> 2012-06-15 18:46:03,201 (http-0.0.0.0-8443-6) [
>> LoginWorker.java:721:INFO ] Running autoLogin check./
>>
>>
>> Thus I speculated that some where while adding the product to the shopping
>> list some error is happening.
>>
>> Excuse me if the above error console looks too congested.
>>
>> Bhargav
>>
>> --
>> View this message in context: http://ofbiz.135035.n4.nabble.**
>> com/Product-not-found-for-**Product-ID-tp4633348p4633627.**html<http://ofbiz.135035.n4.nabble.com/Product-not-found-for-Product-ID-tp4633348p4633627.html>
>> Sent from the OFBiz - User mailing list archive at Nabble.com.
>>
>> --
>> Thanks,
>> Deepak Agarwal,
>>
>> Paxcel Technologies Pvt Ltd.
>> Hartron Complex, Sector 18, Gurgaon, India.
>> E-Mail: [email protected]
>> Mobile: +91 9910322604
>>
>>

Reply via email to