Hi, Jira created https://issues.apache.org/jira/browse/OFBIZ-5553
Thanks Jen Sing On Sat, Mar 1, 2014 at 9:32 PM, Jacques Le Roux < [email protected]> wrote: > Thanks Jen, > > We got lucky that your patch passed through. Normally they don't. Next > time please create rather a Jira issue, see https://cwiki.apache.org/ > confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices > > I will review and test your patch soon. I noticed you did not remove > EditProductParties.ftl. I will certainly do if all is OK. > > I will have a look at the red-when issue also. It seems this does nor work > for a while (not even in R09.04), thanks for the report! > > Jacques > > Le 01/03/2014 13:37, Jen Sing Choe a écrit : > >> Hi, Jacques >> >> please check the attached patch >> summarize >> 1. replace FTL with form widget >> 2. but, the attribute red-when seem like not working >> >> I had also tested the red-when in Ofbiz Demo - ProductForms >> >> https://demo-trunk.ofbiz.apache.org/catalog/control/ >> EditProduct?productId=GZ-2644 >> >> introductionDate, salesDiscontinuationDate >> It seem like not showing the 'red' wording >> >> Regards, >> Jen Sing >> >> >> >> On Fri, Feb 28, 2014 at 5:32 AM, Jacques Le Roux < >> [email protected] <mailto:[email protected]>> >> wrote: >> >> Hi Jen, >> >> Please yes provide your patch. >> >> I don't remember about >> >> >there are also JIRA (if i not mistaken), to substitute >> externalLoginKey implementation >> But if I have well understood you will provide a patch to replace a >> FTL implementation by a form widget one, so this should not be a pb as you >> stated >> >> Thanks >> >> Jacques >> >> >> Le 27/02/2014 02:53, Jen Sing Choe a écrit : >> >> Hi, >> Tested against the ofbiz demo trunk >> >> https://demo-trunk.ofbiz.apache.org/catalog/control/ >> EditProductParties?productId=FORKLIFT_PROPANE >> >> when you click on the hyperlink Party Id >> ofbiz will open in a new tab and asking for authentication again. >> >> https://demo-trunk.ofbiz.apache.org/partymgr/control/ >> viewprofile?partyId=10002 >> >> But in Catalog Manager -> Catalogs -> Parties >> https://demo-trunk.ofbiz.apache.org/catalog/control/ >> EditProdCatalogParties?prodCatalogId=DemoCatalog >> >> this is not a problem, because the form-widget are appending the >> externalLoginKey >> >> I understand (if i not mistaken), that there is previous JIRA >> that are >> going to housekeep ftl to using form widget. >> there are also JIRA (if i not mistaken), to substitute >> externalLoginKey >> implementation >> >> if the above is still valid, then i provide the patch. its a >> simple patch. >> >> >> >> Disclaimer : This E-mail is intended only for the use of the individual >> or entity named above and may contain information that is confidential. If >> you are not the intended recipients, please immediately notify us by return >> email and delete it from your system. Any unauthorised dissemination, >> distribution or copying of this email is strictly prohibited. Thank You. >> > > -- Disclaimer : This E-mail is intended only for the use of the individual or entity named above and may contain information that is confidential. If you are not the intended recipients, please immediately notify us by return email and delete it from your system. Any unauthorised dissemination, distribution or copying of this email is strictly prohibited. Thank You.
